mirror of
https://github.com/elastic/kibana.git
synced 2025-04-23 09:19:04 -04:00
# Backport This will backport the following commits from `main` to `8.15`: - [Make it clear log stream panels shouldn't be used (#187548)](https://github.com/elastic/kibana/pull/187548) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Joe Reuter","email":"johannes.reuter@elastic.co"},"sourceCommit":{"committedDate":"2024-07-08T15:11:27Z","message":"Make it clear log stream panels shouldn't be used (#187548)\n\nAs discussed, I looked into making it clearer how to handle the log\r\nstream embeddable panel on dashboards.\r\n\r\nIt's not possible to show an info icon or a badge without bigger\r\nchanges, but there is already a tooltip which can be used for the same\r\npurpose:\r\n\r\n<img width=\"321\" alt=\"Screenshot 2024-07-04 at 11 30 27\"\r\nsrc=\"60de35b5
-559f-4670-b2b9-e074a3cb73c8\">\r\n\r\n<img width=\"422\" alt=\"Screenshot 2024-07-04 at 11 31 31\"\r\nsrc=\"3ba2f87c
-dc33-4a6b-bf81-2e561e6b7cec\">\r\n\r\nI added the \"deprecated\" to the title instead.\r\n\r\nThere is code to show a \"deprecated\" badge, but it only works for\r\nvisualization types, not for actions (which is how log stream is\r\nintegrated here). Actions currently don't have a notion of deprecation.\r\nIt would be possible to add that, but it doesn't seem worth it to\r\nslightly change how the \"deprecated\" text is rendered.","sha":"bac808a690d58237b3302c706701a81215d963cf","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-logs","apm:review","v8.16.0"],"title":"Make it clear log stream panels shouldn't be used","number":187548,"url":"https://github.com/elastic/kibana/pull/187548","mergeCommit":{"message":"Make it clear log stream panels shouldn't be used (#187548)\n\nAs discussed, I looked into making it clearer how to handle the log\r\nstream embeddable panel on dashboards.\r\n\r\nIt's not possible to show an info icon or a badge without bigger\r\nchanges, but there is already a tooltip which can be used for the same\r\npurpose:\r\n\r\n<img width=\"321\" alt=\"Screenshot 2024-07-04 at 11 30 27\"\r\nsrc=\"60de35b5
-559f-4670-b2b9-e074a3cb73c8\">\r\n\r\n<img width=\"422\" alt=\"Screenshot 2024-07-04 at 11 31 31\"\r\nsrc=\"3ba2f87c
-dc33-4a6b-bf81-2e561e6b7cec\">\r\n\r\nI added the \"deprecated\" to the title instead.\r\n\r\nThere is code to show a \"deprecated\" badge, but it only works for\r\nvisualization types, not for actions (which is how log stream is\r\nintegrated here). Actions currently don't have a notion of deprecation.\r\nIt would be possible to add that, but it doesn't seem worth it to\r\nslightly change how the \"deprecated\" text is rendered.","sha":"bac808a690d58237b3302c706701a81215d963cf"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/187548","number":187548,"mergeCommit":{"message":"Make it clear log stream panels shouldn't be used (#187548)\n\nAs discussed, I looked into making it clearer how to handle the log\r\nstream embeddable panel on dashboards.\r\n\r\nIt's not possible to show an info icon or a badge without bigger\r\nchanges, but there is already a tooltip which can be used for the same\r\npurpose:\r\n\r\n<img width=\"321\" alt=\"Screenshot 2024-07-04 at 11 30 27\"\r\nsrc=\"60de35b5
-559f-4670-b2b9-e074a3cb73c8\">\r\n\r\n<img width=\"422\" alt=\"Screenshot 2024-07-04 at 11 31 31\"\r\nsrc=\"3ba2f87c
-dc33-4a6b-bf81-2e561e6b7cec\">\r\n\r\nI added the \"deprecated\" to the title instead.\r\n\r\nThere is code to show a \"deprecated\" badge, but it only works for\r\nvisualization types, not for actions (which is how log stream is\r\nintegrated here). Actions currently don't have a notion of deprecation.\r\nIt would be possible to add that, but it doesn't seem worth it to\r\nslightly change how the \"deprecated\" text is rendered.","sha":"bac808a690d58237b3302c706701a81215d963cf"}}]}] BACKPORT--> Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
This commit is contained in:
parent
9c5f961c6b
commit
b4cff4dca9
2 changed files with 4 additions and 3 deletions
|
@ -34,7 +34,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
|
|||
await PageObjects.dashboard.clickNewDashboard();
|
||||
await PageObjects.dashboard.switchToEditMode();
|
||||
await dashboardAddPanel.clickEditorMenuButton();
|
||||
await dashboardAddPanel.clickAddNewPanelFromUIActionLink('Log stream');
|
||||
await dashboardAddPanel.clickAddNewPanelFromUIActionLink('Log stream (deprecated)');
|
||||
await dashboardAddPanel.expectEditorMenuClosed();
|
||||
});
|
||||
|
||||
|
|
|
@ -405,11 +405,12 @@ export class Plugin implements InfraClientPluginClass {
|
|||
order: 30,
|
||||
getDisplayName: () =>
|
||||
i18n.translate('xpack.infra.logStreamEmbeddable.displayName', {
|
||||
defaultMessage: 'Log stream',
|
||||
defaultMessage: 'Log stream (deprecated)',
|
||||
}),
|
||||
getDisplayNameTooltip: () =>
|
||||
i18n.translate('xpack.infra.logStreamEmbeddable.description', {
|
||||
defaultMessage: 'Add a table of live streaming logs.',
|
||||
defaultMessage:
|
||||
'Add a table of live streaming logs. For a more efficient experience, we recommend using the Discover Page to create a saved search instead of using Log stream.',
|
||||
}),
|
||||
getIconType: () => 'logsApp',
|
||||
isCompatible: async ({ embeddable }) => {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue