github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[7.4] [Reporting] ESQueue worker error logging fix (#46308) (#46386)

Browse source 
* [Reporting] ESQueue worker error logging fix (#46308)

* [Reporting/ESQueue] data read/write failures are error logs (#45478) (#45677)

* [Reporting/ESQueue] data read/write failures are error logs

* fix warning level
This commit is contained in:
Tim Sullivan 2019-09-30 11:20:33 -07:00 • committed by GitHub
parent b6835da5cc
commit b4ec33fc2c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

15
x-pack/legacy/plugins/reporting/server/lib/esqueue/worker.js
View file

@ -55,6 +55,8 @@ function getLogger(opts, id, logLevel) {
`The entire error message length is: ${errLength} characters.`,
tags
);
} else {
logger(errString, tags);
}
return;
}
@ -83,7 +85,8 @@ export class Worker extends events.EventEmitter {
this.checkSize = opts.size || 10;
this.debug = getLogger(opts, this.id, 'debug');
this.warn = getLogger(opts, this.id, 'warn');
this.warn = getLogger(opts, this.id, 'warning');
this.error = getLogger(opts, this.id, 'error');
this.info = getLogger(opts, this.id, 'info');
this._running = true;
@ -197,7 +200,7 @@ export class Worker extends events.EventEmitter {
.then(() => true)
.catch((err) => {
if (err.statusCode === 409) return true;
this.warn(`_failJob failed to update job ${job._id}`, err);
this.error(`_failJob failed to update job ${job._id}`, err);
this.emit(constants.EVENT_WORKER_FAIL_UPDATE_ERROR, this._formatErrorParams(err, job));
return false;
});
@ -290,7 +293,7 @@ export class Worker extends events.EventEmitter {
})
.catch((err) => {
if (err.statusCode === 409) return false;
this.warn(`Failure saving job output ${job._id}`, err);
this.error(`Failure saving job output ${job._id}`, err);
this.emit(constants.EVENT_WORKER_JOB_UPDATE_ERROR, this._formatErrorParams(err, job));
return this._failJob(job, (err.message) ? err.message : false);
});
@ -316,7 +319,7 @@ export class Worker extends events.EventEmitter {
}
}
this.warn(`Failure occurred on job ${job._id}`, jobErr);
this.error(`Failure occurred on job ${job._id}`, jobErr);
this.emit(constants.EVENT_WORKER_JOB_EXECUTION_ERROR, this._formatErrorParams(jobErr, job));
return this._failJob(job, (jobErr.toString) ? jobErr.toString() : false);
});
@ -376,7 +379,7 @@ export class Worker extends events.EventEmitter {
return this._performJob(claimedJob);
})
.catch((err) => {
this.warn('Error claiming jobs', err);
this.error('Error claiming jobs', err);
return Promise.reject(err);
});
}
@ -430,7 +433,7 @@ export class Worker extends events.EventEmitter {
// ignore missing indices errors
if (err && err.status === 404) return [];
this.warn('job querying failed', err);
this.error('job querying failed', err);
this.emit(constants.EVENT_WORKER_JOB_SEARCH_ERROR, this._formatErrorParams(err));
throw err;
});