github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

[7.x] [ci/failed_tests_reporter] when Github 500s, retry up to… (#47853)

Browse source 
* [ci/failed_tests_reporter] when Github 500s, retry up to 5 times

* remove unused import

* properly handle non-string headers
This commit is contained in:
Spencer 2019-10-10 12:53:03 -07:00 • committed by GitHub
parent 1008c9d07e
commit b5220c648d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 62 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

86
packages/kbn-test/src/failed_tests_reporter/github_api.ts
View file

@ -21,7 +21,7 @@ import Url from 'url';
import Axios, { AxiosRequestConfig } from 'axios';
import parseLinkHeader from 'parse-link-header';
import { ToolingLog, isAxiosResponseError } from '@kbn/dev-utils';
import { ToolingLog, isAxiosResponseError, isAxiosRequestError } from '@kbn/dev-utils';
const BASE_URL = 'https://api.github.com/repos/elastic/kibana/';
@ -33,7 +33,11 @@ export interface GithubIssue {
body: string;
}
type RequestOptions = AxiosRequestConfig & { safeForDryRun?: boolean };
type RequestOptions = AxiosRequestConfig & {
safeForDryRun?: boolean;
maxAttempts?: number;
attempt?: number;
};
export class GithubApi {
private readonly x = Axios.create({
@ -78,7 +82,8 @@ export class GithubApi {
issues.push(issue);
}
const parsed = parseLinkHeader(resp.headers.link);
const parsed =
typeof resp.headers.link === 'string' ? parseLinkHeader(resp.headers.link) : undefined;
if (parsed && parsed.next && parsed.next.url) {
nextRequest = {
safeForDryRun: true,
@ -139,31 +144,64 @@ export class GithubApi {
return resp.data.html_url;
}
private async request<T>(options: RequestOptions, dryRunResponse: T) {
private async request<T>(
options: RequestOptions,
dryRunResponse: T
): Promise<{
status: number;
statusText: string;
headers: Record<string, string | string[] | undefined>;
data: T;
}> {
const executeRequest = !this.dryRun || options.safeForDryRun;
const maxAttempts = options.maxAttempts || 5;
const attempt = options.attempt || 1;
this.log.verbose('Github API', executeRequest ? 'Request' : 'Dry Run', options);
if (executeRequest) {
try {
return await this.x.request<T>(options);
} catch (error) {
if (isAxiosResponseError(error)) {
throw new Error(
`[${error.config.method} ${error.config.url}] ${error.response.status} ${
error.response.statusText
} Error: ${JSON.stringify(error.response.data)}`
);
}
throw error;
}
if (!executeRequest) {
return {
status: 200,
statusText: 'OK',
headers: {},
data: dryRunResponse,
};
}
return {
status: 200,
statusText: 'OK',
headers: {},
data: dryRunResponse,
};
try {
return await this.x.request<T>(options);
} catch (error) {
const unableToReachGithub = isAxiosRequestError(error);
const githubApiFailed = isAxiosResponseError(error) && error.response.status >= 500;
const errorResponseLog =
isAxiosResponseError(error) &&
`[${error.config.method} ${error.config.url}] ${error.response.status} ${error.response.statusText} Error`;
if ((unableToReachGithub || githubApiFailed) && attempt < maxAttempts) {
const waitMs = 1000 * attempt;
if (errorResponseLog) {
this.log.error(`${errorResponseLog}: waiting ${waitMs}ms to retry`);
} else {
this.log.error(`Unable to reach github, waiting ${waitMs}ms to retry`);
}
await new Promise(resolve => setTimeout(resolve, waitMs));
return await this.request<T>(
{
...options,
maxAttempts,
attempt: attempt + 1,
},
dryRunResponse
);
}
if (errorResponseLog) {
throw new Error(`${errorResponseLog}: ${JSON.stringify(error.response.data)}`);
}
throw error;
}
}
}