github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

[SIEM] Remove redundant props.key access in kpi stat items (#37461)

Browse source 
* remove redundant key access

* update snapshot
This commit is contained in:
Angela Chuang 2019-05-31 22:04:55 +08:00 • committed by GitHub
parent 9417c16e14
commit b8f94a6eff
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

12
x-pack/plugins/siem/public/components/stat_items/__snapshots__/index.test.tsx.snap generated
View file

@ -14,9 +14,7 @@ exports[`Stat Items disable charts it renders the default widget 1`] = `
] ]
} }
> >
<Styled(EuiFlexItem) <Styled(EuiFlexItem)>
key="stat-items-undefined"
>
<EuiFlexItem <EuiFlexItem
className="sc-bxivhb bQCHAr" className="sc-bxivhb bQCHAr"
> >
@ -120,9 +118,7 @@ exports[`Stat Items disable charts it renders the default widget 2`] = `
] ]
} }
> >
<Styled(EuiFlexItem) <Styled(EuiFlexItem)>
key="stat-items-undefined"
>
<EuiFlexItem <EuiFlexItem
className="sc-bxivhb bQCHAr" className="sc-bxivhb bQCHAr"
> >
@ -299,9 +295,7 @@ exports[`Stat Items rendering kpis with charts it renders the default widget 1`]
] ]
} }
> >
<Styled(EuiFlexItem) <Styled(EuiFlexItem)>
key="stat-items-undefined"
>
<EuiFlexItem <EuiFlexItem
className="sc-bxivhb bQCHAr" className="sc-bxivhb bQCHAr"
> >

4
x-pack/plugins/siem/public/components/stat_items/index.tsx
View file

@ -55,7 +55,7 @@ export interface StatItemsProps extends StatItems {
} }
export const StatItemsComponent = React.memo<StatItemsProps>( export const StatItemsComponent = React.memo<StatItemsProps>(
({ fields, description, key, grow, barChart, areaChart, enableAreaChart, enableBarChart }) => { ({ fields, description, grow, barChart, areaChart, enableAreaChart, enableBarChart }) => {
const isBarChartDataAbailable = const isBarChartDataAbailable =
barChart && barChart &&
barChart.length && barChart.length &&
@ -65,7 +65,7 @@ export const StatItemsComponent = React.memo<StatItemsProps>(
areaChart.length && areaChart.length &&
areaChart.every(item => item.value != null && item.value.length > 0); areaChart.every(item => item.value != null && item.value.length > 0);
return ( return (
<FlexItem key={`stat-items-${key}`} grow={grow}> <FlexItem grow={grow}>
<EuiPanel> <EuiPanel>
<EuiTitle size="xxxs"> <EuiTitle size="xxxs">
<h6>{description}</h6> <h6>{description}</h6>