github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

Disallow dashes in namespace strings (#83996) (#84133)

Browse source 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Jen Huang 2020-11-23 12:14:30 -08:00 • committed by GitHub
parent 28e256c97f
commit b93b26507c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
x-pack/plugins/fleet/common/services/is_valid_namespace.test.ts
View file

@ -8,7 +8,6 @@ import { isValidNamespace } from './is_valid_namespace';
describe('Fleet - isValidNamespace', () => {
it('returns true for valid namespaces', () => {
expect(isValidNamespace('default').valid).toBe(true);
expect(isValidNamespace('namespace-with-dash').valid).toBe(true);
expect(isValidNamespace('123').valid).toBe(true);
expect(isValidNamespace('testlength😀😀😀😀😀😀😀😀😀😀😀😀😀😀😀😀😀😀😀😀😀😀').valid).toBe(
true
@ -19,6 +18,7 @@ describe('Fleet - isValidNamespace', () => {
expect(isValidNamespace('').valid).toBe(false);
expect(isValidNamespace(' ').valid).toBe(false);
expect(isValidNamespace('Default').valid).toBe(false);
expect(isValidNamespace('namespace-with-dash').valid).toBe(false);
expect(isValidNamespace('namespace with spaces').valid).toBe(false);
expect(isValidNamespace('foo/bar').valid).toBe(false);
expect(isValidNamespace('foo\\bar').valid).toBe(false);

2
x-pack/plugins/fleet/common/services/is_valid_namespace.ts
View file

@ -23,7 +23,7 @@ export function isValidNamespace(namespace: string): { valid: boolean; error?: s
defaultMessage: 'Namespace must be lowercase',
}),
};
} else if (/[\*\\/\?"<>|\s,#:]+/.test(namespace)) {
} else if (/[\*\\/\?"<>|\s,#:-]+/.test(namespace)) {
return {
valid: false,
error: i18n.translate('xpack.fleet.namespaceValidation.invalidCharactersErrorMessage', {