github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Lens] Formula Icon, Button, Height Design Update (#103682)

Browse source 
* apply `fullScreenEdit` icon; fix docs button size

* fix small viewport height flex issue
This commit is contained in:
Michael Marcialis 2021-06-29 16:41:45 -04:00 • committed by GitHub
parent 682d969190
commit b9bbfa3695
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

15
x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/formula/editor/formula.scss
View file

@ -47,8 +47,16 @@
}
.lnsFormula__editorContent {
min-height: 0;
position: relative;
height: 201px;
.lnsIndexPatternDimensionEditor:not(.lnsIndexPatternDimensionEditor-isFullscreen) & {
height: 200px;
}
.lnsIndexPatternDimensionEditor-isFullscreen & {
flex: 1;
}
}
.lnsFormula__editorPlaceholder {
@ -62,11 +70,6 @@
pointer-events: none;
}
.lnsIndexPatternDimensionEditor-isFullscreen .lnsFormula__editorContent {
flex: 1;
min-height: 201px;
}
.lnsFormula__warningText + .lnsFormula__warningText {
margin-top: $euiSizeS;
border-top: $euiBorderThin;

4
x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/formula/editor/formula_editor.tsx
View file

@ -622,7 +622,6 @@ export function FormulaEditor({
</EuiFlexItem>
<EuiFlexItem className="lnsFormula__editorHeaderGroup" grow={false}>
{/* TODO: Replace `bolt` with `fullScreenExit` icon (after latest EUI is deployed). */}
<EuiButtonEmpty
onClick={() => {
toggleFullscreen();
@ -630,7 +629,7 @@ export function FormulaEditor({
setIsHelpOpen(!isFullscreen);
trackUiEvent('toggle_formula_fullscreen');
}}
iconType={isFullscreen ? 'bolt' : 'fullScreen'}
iconType={isFullscreen ? 'fullScreenExit' : 'fullScreen'}
size="xs"
color="text"
flush="right"
@ -758,7 +757,6 @@ export function FormulaEditor({
}}
iconType="documentation"
color="text"
size="s"
aria-label={i18n.translate(
'xpack.lens.formula.editorHelpInlineShowToolTip',
{