github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[SIEM] Remove redundant props.key access in kpi stat items (#37461) (#37659)

Browse source 
* remove redundant key access

* update snapshot
This commit is contained in:
Angela Chuang 2019-06-01 00:17:28 +08:00 • committed by GitHub
parent 1212057345
commit ba6e295e42
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

12
x-pack/plugins/siem/public/components/stat_items/__snapshots__/index.test.tsx.snap generated
View file

@ -14,9 +14,7 @@ exports[`Stat Items disable charts it renders the default widget 1`] = `
]
}
>
<Styled(EuiFlexItem)
key="stat-items-undefined"
>
<Styled(EuiFlexItem)>
<EuiFlexItem
className="sc-bxivhb bQCHAr"
>
@ -120,9 +118,7 @@ exports[`Stat Items disable charts it renders the default widget 2`] = `
]
}
>
<Styled(EuiFlexItem)
key="stat-items-undefined"
>
<Styled(EuiFlexItem)>
<EuiFlexItem
className="sc-bxivhb bQCHAr"
>
@ -299,9 +295,7 @@ exports[`Stat Items rendering kpis with charts it renders the default widget 1`]
]
}
>
<Styled(EuiFlexItem)
key="stat-items-undefined"
>
<Styled(EuiFlexItem)>
<EuiFlexItem
className="sc-bxivhb bQCHAr"
>

4
x-pack/plugins/siem/public/components/stat_items/index.tsx
View file

@ -55,7 +55,7 @@ export interface StatItemsProps extends StatItems {
}
export const StatItemsComponent = React.memo<StatItemsProps>(
({ fields, description, key, grow, barChart, areaChart, enableAreaChart, enableBarChart }) => {
({ fields, description, grow, barChart, areaChart, enableAreaChart, enableBarChart }) => {
const isBarChartDataAbailable =
barChart &&
barChart.length &&
@ -65,7 +65,7 @@ export const StatItemsComponent = React.memo<StatItemsProps>(
areaChart.length &&
areaChart.every(item => item.value != null && item.value.length > 0);
return (
<FlexItem key={`stat-items-${key}`} grow={grow}>
<FlexItem grow={grow}>
<EuiPanel>
<EuiTitle size="xxxs">
<h6>{description}</h6>