github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-06-27 18:51:07 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Flaky test #90578] Unskip test (#163696)

Browse source 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Alejandro Fernández Haro 2023-08-24 15:02:34 +02:00 • committed by GitHub
parent 0cfa3e2080
commit ba843882a7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 23 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

1
packages/core/fatal-errors/core-fatal-errors-browser-internal/src/__snapshots__/fatal_errors_screen.test.tsx.snap generated
View file

@ -2,6 +2,7 @@
exports[`FatalErrorsScreen rendering render matches snapshot 1`] = ` exports[`FatalErrorsScreen rendering render matches snapshot 1`] = `
<EuiPage <EuiPage
data-test-subj="fatalErrorScreen"
style={ style={
Object { Object {
"alignItems": "center", "alignItems": "center",

5
packages/core/fatal-errors/core-fatal-errors-browser-internal/src/fatal_errors_screen.tsx
View file

@ -75,7 +75,10 @@ export class FatalErrorsScreen extends React.Component<Props, State> {
public render() { public render() {
return ( return (
<EuiPage style={{ minHeight: '100vh', alignItems: 'center' }}> <EuiPage
style={{ minHeight: '100vh', alignItems: 'center' }}
data-test-subj="fatalErrorScreen"
>
<EuiPageBody> <EuiPageBody>
<EuiPageSection alignment="center"> <EuiPageSection alignment="center">
<EuiEmptyPrompt <EuiEmptyPrompt

6
packages/core/fatal-errors/core-fatal-errors-browser-internal/src/fatal_errors_service.tsx
View file

@ -109,7 +109,11 @@ export class FatalErrorsService {
private setupGlobalErrorHandlers() { private setupGlobalErrorHandlers() {
if (window.addEventListener) { if (window.addEventListener) {
window.addEventListener('unhandledrejection', (e) => { window.addEventListener('unhandledrejection', (e) => {
console.log(`Detected an unhandled Promise rejection.\n${e.reason}`); // eslint-disable-line no-console const { message, stack } = getErrorInfo(e.reason);
// eslint-disable-next-line no-console
console.log(`Detected an unhandled Promise rejection.\n
Message: ${message}\n
Stack: ${stack}`);
}); });
} }
} }

12
test/functional/page_objects/common_page.ts
View file

@ -227,6 +227,7 @@ export class CommonPageObject extends FtrService {
search = '', search = '',
disableWelcomePrompt = true, disableWelcomePrompt = true,
insertTimestamp = true, insertTimestamp = true,
retryOnFatalError = true,
} = {} } = {}
) { ) {
let appUrl: string; let appUrl: string;
@ -293,6 +294,13 @@ export class CommonPageObject extends FtrService {
this.log.debug(msg); this.log.debug(msg);
throw new Error(msg); throw new Error(msg);
} }
if (retryOnFatalError && (await this.isFatalErrorScreen())) {
const msg = `Fatal error screen shown. Let's try refreshing the page once more.`;
this.log.debug(msg);
throw new Error(msg);
}
if (appName === 'discover') { if (appName === 'discover') {
await this.browser.setLocalStorageItem('data.autocompleteFtuePopover', 'true'); await this.browser.setLocalStorageItem('data.autocompleteFtuePopover', 'true');
} }
@ -402,6 +410,10 @@ export class CommonPageObject extends FtrService {
return await this.testSubjects.exists('kbnAppWrapper hiddenChrome'); return await this.testSubjects.exists('kbnAppWrapper hiddenChrome');
} }
async isFatalErrorScreen() {
return await this.testSubjects.exists('fatalErrorScreen');
}
async waitForTopNavToBeVisible() { async waitForTopNavToBeVisible() {
await this.retry.try(async () => { await this.retry.try(async () => {
const isNavVisible = await this.testSubjects.exists('top-nav'); const isNavVisible = await this.testSubjects.exists('top-nav');

3
x-pack/test/saved_object_tagging/functional/tests/listing.ts
View file

@ -14,8 +14,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
const PageObjects = getPageObjects(['common', 'security', 'savedObjects', 'tagManagement']); const PageObjects = getPageObjects(['common', 'security', 'savedObjects', 'tagManagement']);
const tagManagementPage = PageObjects.tagManagement; const tagManagementPage = PageObjects.tagManagement;
// FLAKY: https://github.com/elastic/kibana/issues/90578 describe('table listing', () => {
describe.skip('table listing', () => {
before(async () => { before(async () => {
await kibanaServer.importExport.load( await kibanaServer.importExport.load(
'x-pack/test/saved_object_tagging/common/fixtures/es_archiver/functional_base/data.json' 'x-pack/test/saved_object_tagging/common/fixtures/es_archiver/functional_base/data.json'