github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

revert package policy validation that caused issue with input groups (#125657) (#125679)

Browse source 
(cherry picked from commit 35f4ba5362)

Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>
This commit is contained in:
Kibana Machine 2022-02-15 12:15:55 -05:00 • committed by GitHub
parent e29c846d29
commit bc031b47df
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

3
x-pack/plugins/fleet/common/services/validate_package_policy.test.ts
View file

@ -607,7 +607,8 @@ describe('Fleet - validatePackagePolicy()', () => {
});
});
it('returns package policy validation error if input var does not exist', () => {
// TODO enable when https://github.com/elastic/kibana/issues/125655 is fixed
it.skip('returns package policy validation error if input var does not exist', () => {
expect(
validatePackagePolicy(
{

14
x-pack/plugins/fleet/common/services/validate_package_policy.ts
View file

@ -210,15 +210,11 @@ export const validatePackagePolicyConfig = (
}
if (varDef === undefined) {
errors.push(
i18n.translate('xpack.fleet.packagePolicyValidation.nonExistentVarMessage', {
defaultMessage: '{varName} var definition does not exist',
values: {
varName,
},
})
);
return errors;
// TODO return validation error here once https://github.com/elastic/kibana/issues/125655 is fixed
// eslint-disable-next-line no-console
console.debug(`No variable definition for ${varName} found`);
return null;
}
if (varDef.required) {