github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

[data view field editor] Fix runtime field format editor (#148497)

Browse source 
## Summary

When editing a runtime field, the format setting would successfully save
but it wouldn't be shown on subsequent uses of the field editor. Fixed.

Closes https://github.com/elastic/kibana/issues/144517
This commit is contained in:
Matthew Kime 2023-01-09 09:33:12 -06:00 • committed by GitHub
parent f462c1e763
commit bc4e425f2c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/plugins/data_view_field_editor/public/open_editor.tsx
View file

@ -162,6 +162,7 @@ export const getFieldEditorOpener =
// Runtime field
field = {
name: fieldNameToEdit!,
format: dataView.getFormatterForFieldNoDefault(fieldNameToEdit!)?.toJSON(),
...dataView.getRuntimeField(fieldNameToEdit!)!,
};
} else {

9
test/functional/apps/management/_runtime_fields.ts
View file

@ -63,11 +63,20 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await testSubjects.click('editFieldFormat');
await PageObjects.settings.setFieldType('Long');
await PageObjects.settings.setFieldScriptWithoutToggle('emit(6);');
await PageObjects.settings.toggleRow('formatRow');
await PageObjects.settings.setFieldFormat('bytes');
await testSubjects.find('changeWarning');
await PageObjects.settings.clickSaveField();
await PageObjects.settings.confirmSave();
});
it('verify field format', async function () {
await testSubjects.click('editFieldFormat');
const select = await testSubjects.find('editorSelectedFormatId');
expect(await select.getAttribute('value')).to.be('bytes');
await PageObjects.settings.closeIndexPatternFieldEditor();
});
it('should delete runtime field', async function () {
await testSubjects.click('deleteField');
await PageObjects.settings.confirmDelete();