github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

Add waitUntilLoadingHasFinished in failing tests (#205485)

Browse source 
Fixes: https://github.com/elastic/kibana/issues/205535
Fixes: https://github.com/elastic/kibana/issues/205514
Fixes: https://github.com/elastic/kibana/issues/205498
Fixes: https://github.com/elastic/kibana/issues/205464
Fixes: https://github.com/elastic/kibana/issues/205456
Fixes: https://github.com/elastic/kibana/issues/205453
Fixes: https://github.com/elastic/kibana/issues/205450
Fixes: https://github.com/elastic/kibana/issues/205412
Fixes: https://github.com/elastic/kibana/issues/205410
Fixes: https://github.com/elastic/kibana/issues/205401
Fixes: https://github.com/elastic/kibana/issues/205400
Fixes: https://github.com/elastic/kibana/issues/205399
Fixes: https://github.com/elastic/kibana/issues/205350
Fixes: https://github.com/elastic/kibana/issues/205349
Fixes: https://github.com/elastic/kibana/issues/205316
Fixes: https://github.com/elastic/kibana/issues/205288
Fixes: https://github.com/elastic/kibana/issues/205287

## Summary
It seems that the step tabs are not loading fast enough for the tests to
find the expected element in a [bunch of
test](https://github.com/elastic/kibana/issues?q=is%3Aopen%20label%3A%22Team%3AKibana%20Management%22%20label%3A%22failed-test%22%20created%3A%3E%40today-1w%20).
This PR attempt to fix it. It also adds the
`data-test-subj="indexModeValue"` tag in `TabSummary` that was missing.
This commit is contained in:
Sonia Sanz Vivas 2025-01-08 11:51:34 +01:00 • committed by GitHub
parent 5c13e901ac
commit bcdf942b94
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 31 additions and 51 deletions
Download patch file Download diff file Expand all files Collapse all files

2
x-pack/platform/plugins/shared/index_management/public/application/sections/home/template_list/template_details/tabs/tab_summary.tsx
View file

@ -234,7 +234,7 @@ export const TabSummary: React.FunctionComponent<Props> = ({ templateDetails })
defaultMessage="Index mode"
/>
</EuiDescriptionListTitle>
<EuiDescriptionListDescription>
<EuiDescriptionListDescription data-test-subj="indexModeValue">
{indexModeLabels[indexMode]}
</EuiDescriptionListDescription>
</>

33
x-pack/test/functional/apps/index_management/data_streams_tab/data_streams_tab.ts
View file

@ -282,6 +282,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
// Click update template
await pageObjects.indexManagement.clickNextButton();
await pageObjects.header.waitUntilLoadingHasFinished();
// Verify index mode and close detail tab
expect(await testSubjects.getVisibleText('indexModeValue')).to.be(indexModeName);
@ -322,11 +323,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
await changeIndexMode('index_mode_logsdb');
// Navigate to the last step of the wizard
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('formWizardStep-5');
await pageObjects.header.waitUntilLoadingHasFinished();
await verifyModeHasBeenChanged(INDEX_MODE.LOGSDB);
});
@ -339,11 +337,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
await changeIndexMode('index_mode_standard');
// Navigate to the last step of the wizard
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('formWizardStep-5');
await pageObjects.header.waitUntilLoadingHasFinished();
await verifyModeHasBeenChanged(INDEX_MODE.STANDARD);
});
@ -357,16 +352,15 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
await changeIndexMode('index_mode_logsdb');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('formWizardStep-2');
await pageObjects.header.waitUntilLoadingHasFinished();
// Modify Index settings
await testSubjects.setValue('kibanaCodeEditor', '{}', {
clearWithKeyboard: true,
});
// Navigate to the last step of the wizard
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('formWizardStep-5');
await pageObjects.header.waitUntilLoadingHasFinished();
await verifyModeHasBeenChanged(INDEX_MODE.LOGSDB);
});
@ -379,8 +373,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
await changeIndexMode('index_mode_time_series');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('formWizardStep-2');
await pageObjects.header.waitUntilLoadingHasFinished();
// Modify Index settings
await testSubjects.setValue(
'kibanaCodeEditor',
@ -390,9 +384,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
}
);
// Navigate to the last step of the wizard
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('formWizardStep-5');
await pageObjects.header.waitUntilLoadingHasFinished();
await verifyModeHasBeenChanged(INDEX_MODE.TIME_SERIES);
});

14
x-pack/test/functional/apps/index_management/index_templates_tab/index_template_tab.ts
View file

@ -47,11 +47,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
await testSubjects.click('show-filters-button');
await testSubjects.click('filter-option-h');
// Navigate to the last step of the wizard
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('formWizardStep-5');
await pageObjects.header.waitUntilLoadingHasFinished();
expect(await testSubjects.getVisibleText('lifecycleValue')).to.be('7 hours');
@ -71,11 +68,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
await testSubjects.click('index_mode_logsdb');
// Navigate to the last step of the wizard
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('formWizardStep-5');
await pageObjects.header.waitUntilLoadingHasFinished();
expect(await testSubjects.exists('indexModeTitle')).to.be(true);
expect(await testSubjects.getVisibleText('indexModeValue')).to.be('LogsDB');

31
x-pack/test_serverless/functional/test_suites/common/management/index_management/data_streams.ts
View file

@ -199,6 +199,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
// Click update template
await pageObjects.indexManagement.clickNextButton();
await pageObjects.header.waitUntilLoadingHasFinished();
// Verify index mode and close detail tab
expect(await testSubjects.getVisibleText('indexModeValue')).to.be(indexModeName);
@ -246,11 +247,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
await changeIndexMode('index_mode_logsdb');
// Navigate to the last step of the wizard
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('formWizardStep-5');
await pageObjects.header.waitUntilLoadingHasFinished();
await verifyModeHasBeenChanged(INDEX_MODE.LOGSDB);
});
@ -263,11 +261,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
await changeIndexMode('index_mode_standard');
// Navigate to the last step of the wizard
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('formWizardStep-5');
await pageObjects.header.waitUntilLoadingHasFinished();
await verifyModeHasBeenChanged(INDEX_MODE.STANDARD);
});
@ -281,16 +276,14 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
await changeIndexMode('index_mode_logsdb');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('formWizardStep-2');
await pageObjects.header.waitUntilLoadingHasFinished();
// Modify Index settings
await testSubjects.setValue('kibanaCodeEditor', '{}', {
clearWithKeyboard: true,
});
// Navigate to the last step of the wizard
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('formWizardStep-5');
await verifyModeHasBeenChanged(INDEX_MODE.LOGSDB);
});
@ -303,8 +296,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
await changeIndexMode('index_mode_time_series');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('formWizardStep-2');
await pageObjects.header.waitUntilLoadingHasFinished();
// Modify Index settings
await testSubjects.setValue(
'kibanaCodeEditor',
@ -314,9 +307,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
}
);
// Navigate to the last step of the wizard
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('formWizardStep-5');
await verifyModeHasBeenChanged(INDEX_MODE.TIME_SERIES);
});

2
x-pack/test_serverless/functional/test_suites/common/management/index_management/index_templates.ts
View file

@ -117,10 +117,12 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
// Click form summary step and then the submit button
await testSubjects.click('formWizardStep-5');
await pageObjects.header.waitUntilLoadingHasFinished();
expect(await testSubjects.getVisibleText('indexModeValue')).to.be('LogsDB');
// Click update template
await pageObjects.indexManagement.clickNextButton();
await pageObjects.header.waitUntilLoadingHasFinished();
// Close detail tab
expect(await testSubjects.getVisibleText('indexModeValue')).to.be('LogsDB');