github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

Allow null description field value to round trip from server (#142540)

Browse source
This commit is contained in:
Byron Hulcher 2022-10-04 08:17:17 -04:00 • committed by GitHub
parent 8e770bb608
commit bcfa351f06
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

8
x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/api/connector/update_connector_name_and_description_api_logic.ts
View file

@ -16,17 +16,15 @@ export type PutConnectorNameAndDescriptionArgs = Partial<
indexName: string;
};
export type PutConnectorNameAndDescriptionResponse = Partial<
Pick<Connector, 'name' | 'description'>
> & {
export type PutConnectorNameAndDescriptionResponse = Pick<Connector, 'name' | 'description'> & {
indexName: string;
};
export const putConnectorNameAndDescription = async ({
connectorId,
description,
description = null,
indexName,
name,
name = '',
}: PutConnectorNameAndDescriptionArgs) => {
const route = `/internal/enterprise_search/connectors/${connectorId}/name_and_description`;

2
x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/connector/connector_name_and_description/connector_name_and_description.tsx
View file

@ -65,7 +65,7 @@ export const ConnectorNameAndDescription: React.FC = () => {
title: NAME_LABEL,
},
{
description: description ?? '--',
description: description || '--',
title: DESCRIPTION_LABEL,
},
]}

4
x-pack/plugins/enterprise_search/server/routes/enterprise_search/connectors.ts
View file

@ -254,8 +254,8 @@ export function registerConnectorRoutes({ router, log }: RouteDependencies) {
connectorId: schema.string(),
}),
body: schema.object({
name: schema.maybe(schema.string()),
description: schema.maybe(schema.string()),
name: schema.string(),
description: schema.nullable(schema.string()),
}),
},
},