github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

[APM] Fix custom link filter select value (#137025)

Browse source 
* [APM] Fix custom link filters to clear values after selecting field (#126066)

* adds line comment

* adds e2e test to validate the fix
This commit is contained in:
Oliver Gupte 2022-07-25 11:16:28 -04:00 • committed by GitHub
parent b8b57d530d
commit bd5abb1c80
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

13
x-pack/plugins/apm/ftr_e2e/cypress/integration/power_user/settings/custom_links.spec.ts
View file

@ -34,4 +34,17 @@ describe('Custom links', () => {
cy.get('[data-test-subj="editCustomLink"]').click();
cy.contains('Delete').click();
});
it('clears filter values when field is selected', () => {
cy.visit(basePath);
cy.contains('Create custom link').click();
cy.get('[data-test-subj="filter-0"]').select('service.name');
cy.get(
'[data-test-subj="service.name.value"] [data-test-subj="comboBoxSearchInput"]'
).type('foo');
cy.get('[data-test-subj="filter-0"]').select('service.environment');
cy.get(
'[data-test-subj="service.environment.value"] [data-test-subj="comboBoxInput"]'
).should('not.contain', 'foo');
});
});

4
x-pack/plugins/apm/public/components/app/settings/custom_link/create_edit_custom_link_flyout/filters_section.tsx
View file

@ -108,7 +108,8 @@ export function FiltersSection({
}
)}
onChange={(e) =>
onChangeFilter(e.target.value as FilterKey, value, idx)
// set value to empty string to reset value when new field is selected
onChangeFilter(e.target.value as FilterKey, '', idx)
}
isInvalid={
!isEmpty(value) &&
@ -118,6 +119,7 @@ export function FiltersSection({
</EuiFlexItem>
<EuiFlexItem>
<SuggestionsSelect
key={key}
dataTestSubj={`${key}.value`}
fieldName={key}
placeholder={i18n.translate(