Fix highlight config so it doesn't require a refresh to apply (#10346)

* Acknowledge doc_table:highlight config even after init

* Use highlightAll on dashboard

src/core_plugins/kibana/public/dashboard/dashboard.js

@@ -78,6 +78,7 @@ app.directive('dashboardApp', function (Notifier, courier, AppState, timefilter,
       let pendingVisCount = _.size(dashboardState.getPanels());
 
       timefilter.enabled = true;
+      dash.searchSource.highlightAll(true);
       courier.setRootSearchSource(dash.searchSource);
 
       // Following the "best practice" of always have a '.' in your ng-models –

src/ui/public/highlight/__tests__/highlight_request.js

@@ -79,4 +79,14 @@ describe('getHighlightRequest', () => {
     const request = getHighlightRequest(queryStringQuery);
     expect(request.fields['*']).to.not.have.property('highlight_query');
   });
+
+  it('should enable/disable highlighting if config is changed', () => {
+    getHighlightRequest = getHighlightRequestProvider(config);
+    let request = getHighlightRequest(queryStringQuery);
+    expect(request).to.not.be(undefined);
+
+    config.set('doc_table:highlight', false);
+    request = getHighlightRequest(queryStringQuery);
+    expect(request).to.be(undefined);
+  });
 });

src/ui/public/highlight/highlight_request.js

@@ -23,11 +23,9 @@ function getHighlightQuery(query) {
 }
 
 export default function getHighlightRequestProvider(config) {
-  if (!config.get('doc_table:highlight')) {
-    return _.noop;
-  }
-
   return function getHighlightRequest(query) {
+    if (!config.get('doc_table:highlight')) return;
+
     const fieldsParams = config.get('doc_table:highlight:all_fields')
       ? { highlight_query: getHighlightQuery(query) }
       : {};