github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-25 10:23:14 -04:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #8396 from ppisljar/fix/mochaDescribeOnly

Browse source 
fixing top_level_describe_filter to allow describe.only in unit tests
This commit is contained in:
Peter Pisljar 2016-09-21 21:23:34 +02:00 • committed by GitHub
commit bde2591501
1 changed files with 29 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

21
src/ui/public/test_harness/test_sharding/setup_top_level_describe_filter.js
View file

@ -67,11 +67,7 @@ export function setupTopLevelDescribeFilter(test) {
let describeCallDepth = 0; let describeCallDepth = 0;
const ignoredCalls = []; const ignoredCalls = [];
// ensure that window.describe isn't messed with by other code const describeInterceptor = function (describeName, describeBody) {
Object.defineProperty(window, 'describe', {
configurable: false,
enumerable: true,
value: function describeInterceptor(describeName, describeBody) {
const context = this; const context = this;
const isTopLevelCall = describeCallDepth === 0; const isTopLevelCall = describeCallDepth === 0;
@ -86,12 +82,23 @@ export function setupTopLevelDescribeFilter(test) {
* note that try/finally won't actually catch the error, it * note that try/finally won't actually catch the error, it
* will continue to propogate up the call stack * will continue to propogate up the call stack
*/ */
let result;
try { try {
describeCallDepth += 1; describeCallDepth += 1;
originalDescribe.call(context, describeName, describeBody); result = originalDescribe.call(context, describeName, describeBody);
} finally { } finally {
describeCallDepth -= 1; describeCallDepth -= 1;
} }
} return result;
};
// to allow describe.only calls. we dont need interceptor as it will call describe internally
describeInterceptor.only = originalDescribe.only;
// ensure that window.describe isn't messed with by other code
Object.defineProperty(window, 'describe', {
configurable: false,
enumerable: true,
value: describeInterceptor
}); });
} }