github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[8.7] [Fleet] Fix missing scrolling bar in categories column (#153181) (#153183)

Browse source 
# Backport

This will backport the following commits from `main` to `8.7`:
- [[Fleet] Fix missing scrolling bar in categories column
(#153181)](https://github.com/elastic/kibana/pull/153181)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cristina
Amico","email":"criamico@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-03-13T16:00:33Z","message":"[Fleet]
Fix missing scrolling bar in categories column (#153181)\n\nCloses
https://github.com/elastic/kibana/issues/149378\r\n\r\n##
Summary\r\nFixing missing scrolling bar in Integrations `categories`
left column. I\r\nreplaced the `sticky` css property with the class
`kbnStickyMenu`\r\ndefined\r\n[here](3c7bf58405/src/core/public/styles/rendering/_base.scss (L47-L51)).\r\nThis
class is applied above a certain breakpoint.\r\n\r\n### Large
viewport\r\nThe categories column is
sticky:\r\n\r\n\r\nhttps://user-images.githubusercontent.com/16084106/224733525-362d6b0c-321a-476d-ae5f-caad45ef3fcc.mov\r\n\r\n###
Smaller viewport\r\nThe categories column now has a scrolling
bar:\r\n\r\n\r\nhttps://user-images.githubusercontent.com/16084106/224733690-b310fb78-1ee3-45a7-bc45-dd29ffdc280b.mov","sha":"bb3f91715e2780238b02e69e80cca83534ee6eff","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","backport:prev-minor","v8.8.0"],"number":153181,"url":"https://github.com/elastic/kibana/pull/153181","mergeCommit":{"message":"[Fleet]
Fix missing scrolling bar in categories column (#153181)\n\nCloses
https://github.com/elastic/kibana/issues/149378\r\n\r\n##
Summary\r\nFixing missing scrolling bar in Integrations `categories`
left column. I\r\nreplaced the `sticky` css property with the class
`kbnStickyMenu`\r\ndefined\r\n[here](3c7bf58405/src/core/public/styles/rendering/_base.scss (L47-L51)).\r\nThis
class is applied above a certain breakpoint.\r\n\r\n### Large
viewport\r\nThe categories column is
sticky:\r\n\r\n\r\nhttps://user-images.githubusercontent.com/16084106/224733525-362d6b0c-321a-476d-ae5f-caad45ef3fcc.mov\r\n\r\n###
Smaller viewport\r\nThe categories column now has a scrolling
bar:\r\n\r\n\r\nhttps://user-images.githubusercontent.com/16084106/224733690-b310fb78-1ee3-45a7-bc45-dd29ffdc280b.mov","sha":"bb3f91715e2780238b02e69e80cca83534ee6eff"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/153181","number":153181,"mergeCommit":{"message":"[Fleet]
Fix missing scrolling bar in categories column (#153181)\n\nCloses
https://github.com/elastic/kibana/issues/149378\r\n\r\n##
Summary\r\nFixing missing scrolling bar in Integrations `categories`
left column. I\r\nreplaced the `sticky` css property with the class
`kbnStickyMenu`\r\ndefined\r\n[here](3c7bf58405/src/core/public/styles/rendering/_base.scss (L47-L51)).\r\nThis
class is applied above a certain breakpoint.\r\n\r\n### Large
viewport\r\nThe categories column is
sticky:\r\n\r\n\r\nhttps://user-images.githubusercontent.com/16084106/224733525-362d6b0c-321a-476d-ae5f-caad45ef3fcc.mov\r\n\r\n###
Smaller viewport\r\nThe categories column now has a scrolling
bar:\r\n\r\n\r\nhttps://user-images.githubusercontent.com/16084106/224733690-b310fb78-1ee3-45a7-bc45-dd29ffdc280b.mov","sha":"bb3f91715e2780238b02e69e80cca83534ee6eff"}}]}]
BACKPORT-->

Co-authored-by: Cristina Amico <criamico@users.noreply.github.com>
This commit is contained in:
Kibana Machine 2023-03-13 13:09:25 -04:00 • committed by GitHub
parent 21c8d91a24
commit bebe42043c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

2
x-pack/plugins/fleet/public/applications/integrations/sections/epm/components/package_list_grid/controls.tsx
View file

@ -49,7 +49,7 @@ export const ControlsColumn = ({ controls, title }: ControlsColumnProps) => {
);
}
return (
<EuiFlexGroup direction="column" gutterSize="none">
<EuiFlexGroup direction="column" gutterSize="none" className="kbnStickyMenu">
{titleContent}
{controls}
</EuiFlexGroup>

10
x-pack/plugins/fleet/public/applications/integrations/sections/epm/components/package_list_grid/index.tsx
View file

@ -161,15 +161,7 @@ export const PackageListGrid: FunctionComponent<Props> = ({
return (
<EuiFlexGroup alignItems="flexStart" gutterSize="xl" data-test-subj="epmList.integrationCards">
<EuiFlexItem
data-test-subj="epmList.controlsSideColumn"
grow={1}
style={{
position: 'sticky',
top: 0,
zIndex: 100,
}}
>
<EuiFlexItem data-test-subj="epmList.controlsSideColumn" grow={1} className="kbnStickyMenu">
<ControlsColumn controls={controls} title={title} />
</EuiFlexItem>
<EuiFlexItem grow={5} data-test-subj="epmList.mainColumn">