github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Custom Threshold Rule] Account for max alerts limits (#171960)

Browse source
This commit is contained in:
Shahzad 2023-12-11 10:00:34 +01:00 • committed by GitHub
parent 08693ff1b7
commit c1bab7b1f0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

12
x-pack/plugins/observability/server/lib/rules/custom_threshold/custom_threshold_executor.ts
View file

@ -99,6 +99,7 @@ export const createCustomThresholdExecutor = ({
getAlertByAlertUuid,
getAlertStartedDate,
searchSourceClient,
alertFactory: baseAlertFactory,
} = services;
const alertFactory: CustomThresholdAlertFactory = (
@ -177,8 +178,17 @@ export const createCustomThresholdExecutor = ({
const hasGroups = !isEqual(groups, [UNGROUPED_FACTORY_KEY]);
let scheduledActionsCount = 0;
const alertLimit = baseAlertFactory.alertLimit.getValue();
let hasReachedLimit = false;
// The key of `groups` is the alert instance ID.
for (const group of groups) {
if (scheduledActionsCount >= alertLimit) {
// need to set this so that warning is displayed in the UI and in the logs
hasReachedLimit = true;
break; // once limit is reached, we break out of the loop and don't schedule any more alerts
}
// AND logic; all criteria must be across the threshold
const shouldAlertFire = alertResults.every((result) => result[group]?.shouldFire);
// AND logic; because we need to evaluate all criteria, if one of them reports no data then the
@ -296,6 +306,8 @@ export const createCustomThresholdExecutor = ({
});
}
}
baseAlertFactory.alertLimit.setLimitReached(hasReachedLimit);
const { getRecoveredAlerts } = services.alertFactory.done();
const recoveredAlerts = getRecoveredAlerts();