github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-25 02:09:32 -04:00
Code Issues Projects Releases Packages Wiki Activity

[APM] Fix trace sample double pagination summary (#57558) (#57982)

Browse source 
* [APM] Remove PaginationContainer

Removing the old pagination from the trace summary title.

* [APM] Removing PaginationContainer component ref

* [APM] Change the vertical alignment to center

* [APM] Leaving the EuiPagination component in place

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This commit is contained in:
Casper Hübertz 2020-02-19 13:36:12 +01:00 • committed by GitHub
parent 75fa271b0d
commit c20e778656
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

34
x-pack/legacy/plugins/apm/public/components/app/TransactionDetails/WaterfallWithSummmary/index.tsx
View file

@ -16,10 +16,8 @@ import {
import { i18n } from '@kbn/i18n'; import { i18n } from '@kbn/i18n';
import { Location } from 'history'; import { Location } from 'history';
import React, { useEffect, useState } from 'react'; import React, { useEffect, useState } from 'react';
import styled from 'styled-components';
import { IBucket } from '../../../../../server/lib/transactions/distribution/get_buckets/transform'; import { IBucket } from '../../../../../server/lib/transactions/distribution/get_buckets/transform';
import { IUrlParams } from '../../../../context/UrlParamsContext/types'; import { IUrlParams } from '../../../../context/UrlParamsContext/types';
import { px, units } from '../../../../style/variables';
import { history } from '../../../../utils/history'; import { history } from '../../../../utils/history';
import { fromQuery, toQuery } from '../../../shared/Links/url_helpers'; import { fromQuery, toQuery } from '../../../shared/Links/url_helpers';
import { LoadingStatePrompt } from '../../../shared/LoadingStatePrompt'; import { LoadingStatePrompt } from '../../../shared/LoadingStatePrompt';
@ -29,20 +27,6 @@ import { MaybeViewTraceLink } from './MaybeViewTraceLink';
import { TransactionTabs } from './TransactionTabs'; import { TransactionTabs } from './TransactionTabs';
import { IWaterfall } from './WaterfallContainer/Waterfall/waterfall_helpers/waterfall_helpers'; import { IWaterfall } from './WaterfallContainer/Waterfall/waterfall_helpers/waterfall_helpers';
const PaginationContainer = styled.div`
margin-left: ${px(units.quarter)};
display: flex;
align-items: center;
> span:first-of-type {
font-weight: 600;
}
> span:last-of-type {
margin-right: ${px(units.half)};
}
`;
interface Props { interface Props {
urlParams: IUrlParams; urlParams: IUrlParams;
location: Location; location: Location;
@ -102,7 +86,7 @@ export const WaterfallWithSummmary: React.FC<Props> = ({
return ( return (
<EuiPanel paddingSize="m"> <EuiPanel paddingSize="m">
<EuiFlexGroup> <EuiFlexGroup>
<EuiFlexItem style={{ flexDirection: 'row', alignItems: 'baseLine' }}> <EuiFlexItem style={{ flexDirection: 'row', alignItems: 'center' }}>
<EuiTitle size="xs"> <EuiTitle size="xs">
<h5> <h5>
{i18n.translate('xpack.apm.transactionDetails.traceSampleTitle', { {i18n.translate('xpack.apm.transactionDetails.traceSampleTitle', {
@ -111,16 +95,12 @@ export const WaterfallWithSummmary: React.FC<Props> = ({
</h5> </h5>
</EuiTitle> </EuiTitle>
{traceSamples && ( {traceSamples && (
<PaginationContainer> <EuiPagination
<span>{sampleActivePage + 1}</span> pageCount={traceSamples.length}
<span>/{traceSamples.length}</span> activePage={sampleActivePage}
<EuiPagination onPageClick={goToSample}
pageCount={traceSamples.length} compressed
activePage={sampleActivePage} />
onPageClick={goToSample}
compressed
/>
</PaginationContainer>
)} )}
</EuiFlexItem> </EuiFlexItem>
<EuiFlexItem> <EuiFlexItem>