[8.x] [ResponseOps][Alerting] Error when submit rule form when using AddFilterPopover in actions (#194600) (#195228)

# Backport This will backport the following commits from `main` to `8.x`: - [[ResponseOps][Alerting] Error when submit rule form when using AddFilterPopover in actions (#194600)](https://github.com/elastic/kibana/pull/194600)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Julia <iuliia.guskova@elastic.co>
2025-04-25 02:09:32 -04:00 · 2024-10-08 00:11:49 +11:00 · 2024-10-08 00:11:49 +11:00 · c3012d8ff8
commit c3012d8ff8
parent a9c7c913d1
3 changed files with 94 additions and 2 deletions
--- a/x-pack/plugins/alerting/server/saved_objects/schemas/raw_rule/v1.ts
+++ b/x-pack/plugins/alerting/server/saved_objects/schemas/raw_rule/v1.ts
@ -167,9 +167,10 @@ const rawRuleAlertsFilterSchema = schema.object({
            isMultiIndex: schema.maybe(schema.boolean()),
            type: schema.maybe(schema.string()),
            key: schema.maybe(schema.string()),
-            params: schema.maybe(schema.recordOf(schema.string(), schema.any())), // better type?
+            params: schema.maybe(schema.any()),
            value: schema.maybe(schema.string()),
            field: schema.maybe(schema.string()),
+            relation: schema.maybe(schema.oneOf([schema.literal('OR'), schema.literal('AND')])),
          }),
          $state: schema.maybe(
            schema.object({
--- a/x-pack/plugins/triggers_actions_ui/public/application/lib/value_validators.ts
+++ b/x-pack/plugins/triggers_actions_ui/public/application/lib/value_validators.ts
@ -20,7 +20,7 @@ const filterQueryRequiredError = i18n.translate(
 export const validateActionFilterQuery = (actionItem: RuleUiAction): string | null => {
  if ('alertsFilter' in actionItem) {
    const query = actionItem?.alertsFilter?.query;
-    if (query && !query.kql) {
+    if (query && !(query.kql || query.filters.length)) {
      return filterQueryRequiredError;
    }
  }
--- a/x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout.ts
+++ b/x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout.ts
@ -253,6 +253,97 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
      await deleteAlerts(alertsToDelete.map((alertItem: { id: string }) => alertItem.id));
    });

+    it('should create an alert with composite query in filter for conditional action', async () => {
+      const alertName = generateUniqueKey();
+      await rules.common.defineIndexThresholdAlert(alertName);
+
+      // filterKuery validation
+      await testSubjects.setValue('filterKuery', 'group:');
+      const filterKueryInput = await testSubjects.find('filterKuery');
+      expect(await filterKueryInput.elementHasClass('euiFieldSearch-isInvalid')).to.eql(true);
+      await testSubjects.setValue('filterKuery', 'group: group-0');
+      expect(await filterKueryInput.elementHasClass('euiFieldSearch-isInvalid')).to.eql(false);
+
+      await testSubjects.click('.slack-alerting-ActionTypeSelectOption');
+      await testSubjects.click('addNewActionConnectorButton-.slack');
+      const slackConnectorName = generateUniqueKey();
+      await testSubjects.setValue('nameInput', slackConnectorName);
+      await testSubjects.setValue('slackWebhookUrlInput', 'https://test.com');
+      await find.clickByCssSelector('[data-test-subj="saveActionButtonModal"]:not(disabled)');
+      const createdConnectorToastTitle = await toasts.getTitleAndDismiss();
+      expect(createdConnectorToastTitle).to.eql(`Created '${slackConnectorName}'`);
+      await testSubjects.click('notifyWhenSelect');
+      await testSubjects.click('onThrottleInterval');
+      await testSubjects.setValue('throttleInput', '10');
+
+      // Alerts search bar (conditional actions)
+      await testSubjects.click('alertsFilterQueryToggle');
+
+      await pageObjects.header.waitUntilLoadingHasFinished();
+      await testSubjects.click('addFilter');
+      // Add first part of query before AND
+      await testSubjects.click('filterFieldSuggestionList');
+      await comboBox.set('filterFieldSuggestionList', '_id');
+      await comboBox.set('filterOperatorList', 'is not');
+      await testSubjects.setValue('filterParams', 'fake-rule-id');
+      await testSubjects.click('add-and-filter');
+      // Add second part of query after AND
+      const firstDropdown = await find.byCssSelector(
+        '[data-test-subj="filter-0.1"] [data-test-subj="filterFieldSuggestionList"] [data-test-subj="comboBoxSearchInput"]'
+      );
+      await firstDropdown.click();
+      await firstDropdown.type('kibana.alert.action_group');
+      await find.clickByButtonText('kibana.alert.action_group');
+      const secondDropdown = await find.byCssSelector(
+        '[data-test-subj="filter-0.1"] [data-test-subj="filterOperatorList"] [data-test-subj="comboBoxSearchInput"]'
+      );
+      await secondDropdown.click();
+      await secondDropdown.type('exists');
+      await find.clickByButtonText('exists');
+      await testSubjects.click('saveFilter');
+      await testSubjects.setValue('queryInput', '_id: *');
+
+      const messageTextArea = await find.byCssSelector('[data-test-subj="messageTextArea"]');
+      expect(await messageTextArea.getAttribute('value')).to.eql(
+        `Rule {{rule.name}} is active for group {{context.group}}:
+
+- Value: {{context.value}}
+- Conditions Met: {{context.conditions}} over {{rule.params.timeWindowSize}}{{rule.params.timeWindowUnit}}
+- Timestamp: {{context.date}}`
+      );
+      await testSubjects.setValue('messageTextArea', 'test message ');
+      await testSubjects.click('messageAddVariableButton');
+      await testSubjects.click('variableMenuButton-alert.actionGroup');
+      expect(await messageTextArea.getAttribute('value')).to.eql(
+        'test message {{alert.actionGroup}}'
+      );
+      await messageTextArea.type(' some additional text ');
+
+      await testSubjects.click('messageAddVariableButton');
+      await testSubjects.setValue('messageVariablesSelectableSearch', 'rule.id');
+      await testSubjects.click('variableMenuButton-rule.id');
+
+      expect(await messageTextArea.getAttribute('value')).to.eql(
+        'test message {{alert.actionGroup}} some additional text {{rule.id}}'
+      );
+      await testSubjects.click('saveRuleButton');
+      const toastTitle = await toasts.getTitleAndDismiss();
+      expect(toastTitle).to.eql(`Created rule "${alertName}"`);
+      await pageObjects.triggersActionsUI.searchAlerts(alertName);
+      const searchResultsAfterSave = await pageObjects.triggersActionsUI.getAlertsList();
+      const searchResultAfterSave = searchResultsAfterSave[0];
+      expect(omit(searchResultAfterSave, 'duration')).to.eql({
+        name: `${alertName}Index threshold`,
+        tags: '',
+        interval: '1 min',
+      });
+      expect(searchResultAfterSave.duration).to.match(/\d{2,}:\d{2}/);
+
+      // clean up created alert
+      const alertsToDelete = await getAlertsByName(alertName);
+      await deleteAlerts(alertsToDelete.map((alertItem: { id: string }) => alertItem.id));
+    });
+
    it('should create an alert with actions in multiple groups', async () => {
      const alertName = generateUniqueKey();
      await defineAlwaysFiringAlert(alertName);