[eslint/console] enable no-undef rule (#10909)

Backports PR #10881

**Commit 1:**
[eslint/console] enable no-undef rule

* Original sha: 9bb2581071
* Authored by spalger <spalger@users.noreply.github.com> on 2017-03-24T04:25:32Z

**Commit 2:**
[eslint/console] fix no-undef violations

* Original sha: ec5cb80289
* Authored by spalger <spalger@users.noreply.github.com> on 2017-03-24T04:25:57Z

src/core_plugins/console/public/.eslintrc

@@ -22,7 +22,6 @@ rules:
   no-nested-ternary: off
   no-proto: off
   no-sequences: off
-  no-undef: off
   no-use-before-define: off
   one-var: off
   quotes: off

src/core_plugins/console/public/src/autocomplete.js

@@ -331,7 +331,6 @@ module.exports = function (editor) {
       case "url.part":
       case "url.param":
       case "url.value":
-        insertingRelativeToToken = 0;
         context.rangeToReplace = new AceRange(
           pos.row, anchorToken.start, pos.row,
           context.updatedForToken.start + context.updatedForToken.value.length
@@ -340,7 +339,6 @@ module.exports = function (editor) {
         break;
       default:
         if (replacingTerm && context.updatedForToken.value == replacingTerm) {
-          insertingRelativeToToken = 0;
           context.rangeToReplace = new AceRange(
             pos.row, anchorToken.start, pos.row,
             context.updatedForToken.start + context.updatedForToken.value.length

src/core_plugins/console/public/src/output.js

@@ -1,3 +1,4 @@
+import _ from 'lodash';
 let ace = require('ace');
 let settings = require('./settings');
 let OutputMode = require('./sense_editor/mode/output');

src/core_plugins/console/public/src/utils.js

@@ -1,3 +1,5 @@
+import _ from 'lodash';
+
 var utils = {};
 
 utils.textFromRequest = function (request) {

src/core_plugins/console/public/tests/src/curl_parsing_tests.js

@@ -2,7 +2,7 @@ let _ = require('lodash');
 let curl = require('../../src/curl');
 let curlTests = require('raw!./curl_parsing_tests.txt');
 
-var { test, module, ok, equal } = QUnit;
+var { test, module, ok, equal } = window.QUnit;
 
 module("CURL");
 

src/core_plugins/console/public/tests/src/editor_tests.js

@@ -1,10 +1,12 @@
+import $ from 'jquery';
+import _ from 'lodash';
 let ace = require('ace');
 import { initializeInput } from '../../src/input';
 let editor_input1 = require('raw!./editor_input1.txt');
 let utils = require('../../src/utils');
 
 var aceRange = ace.require("ace/range");
-var { module, asyncTest, deepEqual, equal, start } = QUnit;
+var { module, asyncTest, deepEqual, equal, start } = window.QUnit;
 
 let input;
 

src/core_plugins/console/public/tests/src/input_tokenization_tests.js

@@ -4,7 +4,7 @@ import { initializeInput } from '../../src/input';
 let input;
 
 var token_iterator = ace.require("ace/token_iterator");
-var { module, asyncTest, deepEqual, start } = QUnit;
+var { module, asyncTest, deepEqual, start } = window.QUnit;
 
 
 module("Input Tokenization", {

src/core_plugins/console/public/tests/src/integration_tests.js

@@ -1,10 +1,11 @@
 import { initializeInput } from '../../src/input';
+import _ from 'lodash';
 let input;
 let kb = require('../../src/kb');
 let mappings = require('../../src/mappings');
 let $ = require('jquery');
 
-var { module, ok, asyncTest, deepEqual, equal, start } = QUnit;
+var { module, ok, asyncTest, deepEqual, equal, start } = window.QUnit;
 
 module("Integration", {
   setup: function () {

src/core_plugins/console/public/tests/src/kb_tests.js

@@ -1,8 +1,9 @@
+import _ from 'lodash';
 let kb = require('../../src/kb');
 let mappings = require('../../src/mappings');
 let autocomplete_engine = require('../../src/autocomplete/engine');
 
-var { test, module, deepEqual } = QUnit;
+var { test, module, deepEqual } = window.QUnit;
 
 module("Knowledge base", {
   setup: function () {

src/core_plugins/console/public/tests/src/mapping_tests.js

@@ -1,6 +1,6 @@
 let mappings = require('../../src/mappings');
 
-var { test, module, deepEqual } = QUnit;
+var { test, module, deepEqual } = window.QUnit;
 
 module("Mappings", {
   setup: function () {
@@ -82,7 +82,7 @@ test("Multi fields 1.0 style", function () {
     f("any_name", "string"), f("first_name", "string"), f("last_name", "string"), f("last_name.raw", "string")]);
 });
 
-QUnit.test("Simple fields", function () {
+test("Simple fields", function () {
   mappings.loadMappings({
     "index": {
       "tweet": {
@@ -101,7 +101,7 @@ QUnit.test("Simple fields", function () {
   deepEqual(mappings.getFields("index").sort(fc), [f("number", "int"), f("str", "string")]);
 });
 
-QUnit.test("Simple fields - 1.0 style", function () {
+test("Simple fields - 1.0 style", function () {
   mappings.loadMappings({
     "index": {
       "mappings": {
@@ -122,7 +122,7 @@ QUnit.test("Simple fields - 1.0 style", function () {
   deepEqual(mappings.getFields("index").sort(fc), [f("number", "int"), f("str", "string")]);
 });
 
-QUnit.test("Nested fields", function () {
+test("Nested fields", function () {
   mappings.loadMappings({
     "index": {
       "tweet": {

src/core_plugins/console/public/tests/src/output_tokenization_tests.js

@@ -5,7 +5,7 @@ import { initializeOutput } from '../../src/output';
 let output;
 
 var token_iterator = ace.require("ace/token_iterator");
-var { module, asyncTest, deepEqual, start } = QUnit;
+var { module, asyncTest, deepEqual, start } = window.QUnit;
 
 
 module("Output Tokenization", {

src/core_plugins/console/public/tests/src/url_autocomplete_tests.js

@@ -2,7 +2,7 @@ let _ = require('lodash');
 let url_pattern_matcher = require('../../src/autocomplete/url_pattern_matcher');
 let autocomplete_engine = require('../../src/autocomplete/engine');
 
-var { test, module, deepEqual } = QUnit;
+var { test, module, deepEqual } = window.QUnit;
 
 module("Url autocomplete");
 

src/core_plugins/console/public/tests/src/url_params_tests.js

@@ -2,7 +2,7 @@ let _ = require('lodash');
 let url_params = require('../../src/autocomplete/url_params');
 let autocomplete_engine = require('../../src/autocomplete/engine');
 
-var { test, module, deepEqual } = QUnit;
+var { test, module, deepEqual } = window.QUnit;
 
 module("Url params");
 

src/core_plugins/console/public/tests/src/utils_tests.js

@@ -3,7 +3,7 @@ let utils = require('../../src/utils');
 let collapsingTests = require('raw!./utils_string_collapsing.txt');
 let expandingTests = require('raw!./utils_string_expanding.txt');
 
-var { test, module, deepEqual } = QUnit;
+var { test, module, deepEqual } = window.QUnit;
 
 module("Utils class");