github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

fix: [Findings > Vulnerabilities tab][SCREEN READER]: Image needs alt="" because it's a decorative image only (#178088)

Browse source 
Closes: https://github.com/elastic/security-team/issues/8708

## Description

The Vulnerabilities tab on the Findings landing (empty prompt view) has
a decorative image that needs an empty alt-text attribute. Screenshot
attached.

### Steps to recreate

1. Open the [Findings Vulnerability
tab](https://kibana.siem.estc.dev/app/security/cloud_security_posture/findings/vulnerabilities)
2. Inspect the decorative image shown using the DevTools
3. Verify the non-empty alt text that should be updated

### What was done? 

`alt` attribute was set to  "" and  `role="presentation"`

### Screen 

<img width="1405" alt="image"
src="39d765a9-635d-4b41-b4c1-1fa786cee4b5">
This commit is contained in:
Alexey Antonov 2024-03-07 15:52:12 +02:00 • committed by GitHub
parent b1ad3228d3
commit c432bbe995
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
x-pack/plugins/cloud_defend/public/components/cloud_defend_page/index.tsx
View file

@ -113,7 +113,7 @@ const packageNotInstalledRenderer = ({
<FullSizeCenteredPage>
<EuiEmptyPrompt
data-test-subj={PACKAGE_NOT_INSTALLED_TEST_SUBJECT}
icon={<EuiImage size="m" margin="m" src={noDataIllustration} alt="no-data-illustration" />}
icon={<EuiImage size="m" margin="m" src={noDataIllustration} alt="" role="presentation" />}
title={
<h2>
<FormattedMessage

2
x-pack/plugins/cloud_security_posture/public/components/no_findings_states.tsx
View file

@ -179,7 +179,7 @@ const ConfigurationFindingsInstalledEmptyPrompt = ({
return (
<EuiEmptyPrompt
data-test-subj={PACKAGE_NOT_INSTALLED_TEST_SUBJECT}
icon={<EuiImage size="fullWidth" src={noDataIllustration} alt="no-data-illustration" />}
icon={<EuiImage size="fullWidth" src={noDataIllustration} alt="" role="presentation" />}
title={
<h2>
<FormattedMessage

2
x-pack/plugins/cloud_security_posture/public/components/no_vulnerabilities_states.tsx
View file

@ -69,7 +69,7 @@ const CnvmIntegrationNotInstalledEmptyPrompt = ({
return (
<EuiEmptyPrompt
data-test-subj={NO_VULNERABILITIES_STATUS_TEST_SUBJ.NOT_INSTALLED}
icon={<EuiImage size="fullWidth" src={noDataIllustration} alt="no-data-illustration" />}
icon={<EuiImage size="fullWidth" src={noDataIllustration} alt="" role="presentation" />}
title={
<h2>
<FormattedHTMLMessage