github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

show drop partial buckets option (#25520) (#26116)

Browse source
This commit is contained in:
Peter Pisljar 2018-11-26 09:11:24 +01:00 • committed by GitHub
parent 4911a10c73
commit c4fd5d341a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 52 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/ui/public/agg_types/controls/drop_partials.html
View file

@ -1,6 +1,6 @@
<div class="checkbox" ng-if="agg.params.field.name === agg.vis.indexPattern.timeFieldName">
<div class="checkbox" ng-if="agg.params.field.name === agg.getIndexPattern().timeFieldName">
<label>
<input ng-model="agg.params.drop_partials" type="checkbox">
<input ng-model="agg.params.drop_partials" type="checkbox" data-test-subj="dropPartialBucketsCheckbox">
Drop partial buckets
&nbsp;
<icon-tip

46
test/functional/apps/visualize/_vertical_bar_chart.js
View file

@ -111,10 +111,56 @@ export default function ({ getService, getPageObjects }) {
await PageObjects.visualize.openInspector();
const data = await PageObjects.visualize.getInspectorTableData();
await PageObjects.visualize.closeInspector();
log.debug(data);
expect(data).to.eql(expectedChartData);
});
it('should have `drop partial buckets` option', async () => {
const fromTime = '2015-09-20 06:31:44.000';
const toTime = '2015-09-22 18:31:44.000';
await PageObjects.header.setAbsoluteRange(fromTime, toTime);
let expectedChartValues = [
82, 218, 341, 440, 480, 517, 522, 446, 403, 321, 258, 172, 95, 55, 38, 24, 3, 4,
11, 14, 17, 38, 49, 115, 152, 216, 315, 402, 446, 513, 520, 474, 421, 307, 230,
170, 99, 48, 30, 15, 10, 2, 8, 7, 17, 34, 37, 104, 153, 241, 313, 404, 492, 512,
503, 473, 379, 293, 277, 156, 56
];
// Most recent failure on Jenkins usually indicates the bar chart is still being drawn?
// return arguments[0].getAttribute(arguments[1]);","args":[{"ELEMENT":"592"},"fill"]}] arguments[0].getAttribute is not a function
// try sleeping a bit before getting that data
await retry.try(async () => {
const data = await PageObjects.visualize.getBarChartData();
log.debug('data=' + data);
log.debug('data.length=' + data.length);
expect(data).to.eql(expectedChartValues);
});
await PageObjects.visualize.toggleOpenEditor(2);
await PageObjects.visualize.clickDropPartialBuckets();
await PageObjects.visualize.clickGo();
expectedChartValues = [
218, 341, 440, 480, 517, 522, 446, 403, 321, 258, 172, 95, 55, 38, 24, 3, 4,
11, 14, 17, 38, 49, 115, 152, 216, 315, 402, 446, 513, 520, 474, 421, 307, 230,
170, 99, 48, 30, 15, 10, 2, 8, 7, 17, 34, 37, 104, 153, 241, 313, 404, 492, 512,
503, 473, 379, 293, 277, 156
];
// Most recent failure on Jenkins usually indicates the bar chart is still being drawn?
// return arguments[0].getAttribute(arguments[1]);","args":[{"ELEMENT":"592"},"fill"]}] arguments[0].getAttribute is not a function
// try sleeping a bit before getting that data
await retry.try(async () => {
const data = await PageObjects.visualize.getBarChartData();
log.debug('data=' + data);
log.debug('data.length=' + data.length);
expect(data).to.eql(expectedChartValues);
});
});
describe.skip('switch between Y axis scale types', () => {
before(initBarChart);
const axisId = 'ValueAxis-1';

4
test/functional/page_objects/visualize_page.js
View file

@ -194,6 +194,10 @@ export function VisualizePageProvider({ getService, getPageObjects }) {
defaultFindTimeout * 2);
}
async clickDropPartialBuckets() {
return await testSubjects.click('dropPartialBucketsCheckbox');
}
async setMarkdownTxt(markdownTxt) {
const input = await testSubjects.find('markdownTextarea');
await input.clearValue();