mirror of
https://github.com/elastic/kibana.git
synced 2025-04-24 01:38:56 -04:00
[8.10] [Security Solution] Expandable flyout - exclude rule creation from using new flyout (#164653) (#164720)
# Backport This will backport the following commits from `main` to `8.10`: - [[Security Solution] Expandable flyout - exclude rule creation from using new flyout (#164653)](https://github.com/elastic/kibana/pull/164653) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"18648970+christineweng@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-08-24T13:59:36Z","message":"[Security Solution] Expandable flyout - exclude rule creation from using new flyout (#164653)\n\n## Summary\r\n\r\nThe alert flyout (expand button in data table) is available in a lot of\r\nplaces in the security app. When creating a new rule, in the rule\r\npreview section, there is an alert table where the flyout is present. In\r\nthis scenario, the rule is not yet set up, sections like the rule\r\nsummary and hover actions are not applicable in this state.\r\n\r\nThis PR reverts the use of the new expandable flyout in the rule\r\ncreation page -> rule preview section. This will revert the flyout to\r\nthe older version and address bugs such as\r\nhttps://github.com/elastic/kibana/issues/164397\r\n\r\n\r\n**How to test**\r\n- First generate some alerts\r\n- Create a new rule and finish the first section\r\n- Click continue to go to the right (rule preview section)\r\n- Pick an alert and click expand\r\n- The old flyout should appear\r\n\r\n\r\n","sha":"c0ce04699f310bbb8c3cdfe71348371f14359130","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Threat Hunting:Investigations","v8.10.0","v8.11.0"],"number":164653,"url":"https://github.com/elastic/kibana/pull/164653","mergeCommit":{"message":"[Security Solution] Expandable flyout - exclude rule creation from using new flyout (#164653)\n\n## Summary\r\n\r\nThe alert flyout (expand button in data table) is available in a lot of\r\nplaces in the security app. When creating a new rule, in the rule\r\npreview section, there is an alert table where the flyout is present. In\r\nthis scenario, the rule is not yet set up, sections like the rule\r\nsummary and hover actions are not applicable in this state.\r\n\r\nThis PR reverts the use of the new expandable flyout in the rule\r\ncreation page -> rule preview section. This will revert the flyout to\r\nthe older version and address bugs such as\r\nhttps://github.com/elastic/kibana/issues/164397\r\n\r\n\r\n**How to test**\r\n- First generate some alerts\r\n- Create a new rule and finish the first section\r\n- Click continue to go to the right (rule preview section)\r\n- Pick an alert and click expand\r\n- The old flyout should appear\r\n\r\n\r\n","sha":"c0ce04699f310bbb8c3cdfe71348371f14359130"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164653","number":164653,"mergeCommit":{"message":"[Security Solution] Expandable flyout - exclude rule creation from using new flyout (#164653)\n\n## Summary\r\n\r\nThe alert flyout (expand button in data table) is available in a lot of\r\nplaces in the security app. When creating a new rule, in the rule\r\npreview section, there is an alert table where the flyout is present. In\r\nthis scenario, the rule is not yet set up, sections like the rule\r\nsummary and hover actions are not applicable in this state.\r\n\r\nThis PR reverts the use of the new expandable flyout in the rule\r\ncreation page -> rule preview section. This will revert the flyout to\r\nthe older version and address bugs such as\r\nhttps://github.com/elastic/kibana/issues/164397\r\n\r\n\r\n**How to test**\r\n- First generate some alerts\r\n- Create a new rule and finish the first section\r\n- Click continue to go to the right (rule preview section)\r\n- Pick an alert and click expand\r\n- The old flyout should appear\r\n\r\n\r\n","sha":"c0ce04699f310bbb8c3cdfe71348371f14359130"}}]}] BACKPORT--> Co-authored-by: christineweng <18648970+christineweng@users.noreply.github.com>
This commit is contained in:
parent
4dfca26de8
commit
c538a872f3
1 changed files with 2 additions and 2 deletions
|
@ -9,7 +9,7 @@ import type { EuiDataGridCellValueElementProps } from '@elastic/eui';
|
|||
import React, { useCallback, useMemo } from 'react';
|
||||
import { useDispatch } from 'react-redux';
|
||||
import { useExpandableFlyoutContext } from '@kbn/expandable-flyout';
|
||||
import { dataTableActions } from '@kbn/securitysolution-data-table';
|
||||
import { dataTableActions, TableId } from '@kbn/securitysolution-data-table';
|
||||
import { useUiSetting$ } from '@kbn/kibana-react-plugin/public';
|
||||
import { ENABLE_EXPANDABLE_FLYOUT_SETTING } from '../../../../../common/constants';
|
||||
import { RightPanelKey } from '../../../../flyout/right';
|
||||
|
@ -97,7 +97,7 @@ const RowActionComponent = ({
|
|||
},
|
||||
};
|
||||
|
||||
if (isSecurityFlyoutEnabled) {
|
||||
if (isSecurityFlyoutEnabled && tableId !== TableId.rulePreview) {
|
||||
openFlyout({
|
||||
right: {
|
||||
id: RightPanelKey,
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue