github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-06-27 10:40:07 -04:00
Code Issues Projects Releases Packages Wiki Activity

Migrate dashboard tests to use UI settings (#136585)

Browse source 
* Updated test to use uiSettings.

* Unskipped embeddable rendering testg.

* Removed timepicker reference that is unused.

* Removed comment of flaky test.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
John Dorlus 2022-07-20 01:03:34 -04:00 • committed by GitHub
parent 9db0728650
commit c652cb4424
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

3
test/functional/apps/dashboard/group1/embeddable_rendering.ts
View file

@ -99,8 +99,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await dashboardExpect.vegaTextsDoNotExist(['5,000']);
};
// FLAKY: https://github.com/elastic/kibana/issues/132865
describe.skip('dashboard embeddable rendering', function describeIndexTests() {
describe('dashboard embeddable rendering', function describeIndexTests() {
before(async () => {
await security.testUser.setRoles(['kibana_admin', 'animals', 'test_logstash_reader']);
await kibanaServer.savedObjects.cleanStandardList();

19
test/functional/apps/dashboard/group1/url_field_formatter.ts
View file

@ -11,18 +11,19 @@ import { WebElementWrapper } from '../../../services/lib/web_element_wrapper';
import { FtrProviderContext } from '../../../ftr_provider_context';
export default function ({ getService, getPageObjects }: FtrProviderContext) {
const { common, dashboard, settings, timePicker, visChart } = getPageObjects([
const { common, dashboard, settings, visChart, discover } = getPageObjects([
'common',
'dashboard',
'settings',
'timePicker',
'visChart',
'discover',
]);
const kibanaServer = getService('kibanaServer');
const testSubjects = getService('testSubjects');
const browser = getService('browser');
const fieldName = 'clientip';
const deployment = getService('deployment');
const retry = getService('retry');
const clickFieldAndCheckUrl = async (fieldLink: WebElementWrapper) => {
const fieldValue = await fieldLink.getVisibleText();
@ -35,8 +36,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(currentUrl).to.equal(fieldUrl);
};
// FLAKY: https://github.com/elastic/kibana/issues/133973
describe.skip('Changing field formatter to Url', () => {
describe('Changing field formatter to Url', () => {
before(async function () {
await kibanaServer.savedObjects.cleanStandardList();
await kibanaServer.importExport.load(
@ -68,12 +68,15 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
it('applied on discover', async () => {
const from = 'Sep 19, 2017 @ 06:31:44.000';
const to = 'Sep 23, 2018 @ 18:31:44.000';
await common.setTime({ from, to });
await common.navigateToApp('discover');
await timePicker.setAbsoluteRange(
'Sep 19, 2017 @ 06:31:44.000',
'Sep 23, 2018 @ 18:31:44.000'
);
await discover.selectIndexPattern('logstash-*');
await testSubjects.click('docTableExpandToggleColumn');
await retry.waitForWithTimeout(`${fieldName} is visible`, 30000, async () => {
return await testSubjects.isDisplayed(`tableDocViewRow-${fieldName}-value`);
});
const fieldLink = await testSubjects.find(`tableDocViewRow-${fieldName}-value`);
await clickFieldAndCheckUrl(fieldLink);
});