github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-25 02:09:32 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fix icon path in tutorial introduction (#49684) (#54570)

Browse source 
Some icons are included as SVG files with relative paths to their
location. Add the base path so these files are correctly displayed when
Kibana is not running from the root path.
This commit is contained in:
Jaime Soriano Pastor 2020-01-13 19:15:22 +01:00 • committed by GitHub
parent a93534f327
commit c68d00f3eb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/legacy/core_plugins/kibana/public/home/np_ready/components/tutorial/tutorial.js
View file

@ -362,6 +362,11 @@ class TutorialUi extends React.Component {
); );
} }
let icon = this.state.tutorial.euiIconType;
if (icon && icon.includes('/')) {
icon = this.props.addBasePath(icon);
}
const instructions = this.getInstructions(); const instructions = this.getInstructions();
content = ( content = (
<div> <div>
@ -370,7 +375,7 @@ class TutorialUi extends React.Component {
description={this.props.replaceTemplateStrings(this.state.tutorial.longDescription)} description={this.props.replaceTemplateStrings(this.state.tutorial.longDescription)}
previewUrl={previewUrl} previewUrl={previewUrl}
exportedFieldsUrl={exportedFieldsUrl} exportedFieldsUrl={exportedFieldsUrl}
iconType={this.state.tutorial.euiIconType} iconType={icon}
isBeta={this.state.tutorial.isBeta} isBeta={this.state.tutorial.isBeta}
/> />

8
src/legacy/core_plugins/kibana/public/home/np_ready/components/tutorial_directory.js
View file

@ -127,9 +127,15 @@ class TutorialDirectoryUi extends React.Component {
} }
let tutorialCards = tutorialConfigs.map(tutorialConfig => { let tutorialCards = tutorialConfigs.map(tutorialConfig => {
// add base path to SVG based icons
let icon = tutorialConfig.euiIconType;
if (icon && icon.includes('/')) {
icon = this.props.addBasePath(icon);
}
return { return {
category: tutorialConfig.category, category: tutorialConfig.category,
icon: tutorialConfig.euiIconType, icon: icon,
name: tutorialConfig.name, name: tutorialConfig.name,
description: tutorialConfig.shortDescription, description: tutorialConfig.shortDescription,
url: this.props.addBasePath(`#/home/tutorial/${tutorialConfig.id}`), url: this.props.addBasePath(`#/home/tutorial/${tutorialConfig.id}`),