github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Monitoring] Use a basic monitoring user for tests (#47865)

Browse source 
* Use a basic monitoring user for tests

* Rework this a little to fix the issue that the tests aren't working properly

* I think this is what we need to fix the tests

* Switch this order, since these tests cause a weird login loop in the current order
This commit is contained in:
Chris Roberson 2019-11-18 11:00:40 -05:00 • committed by GitHub
parent f92573ab57
commit c739e2f50b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 31 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

7
x-pack/test/functional/apps/monitoring/_get_lifecycle_methods.js
View file

@ -6,7 +6,8 @@
export const getLifecycleMethods = (getService, getPageObjects) => { export const getLifecycleMethods = (getService, getPageObjects) => {
const esArchiver = getService('esArchiver'); const esArchiver = getService('esArchiver');
const PageObjects = getPageObjects(['monitoring', 'timePicker']); const security = getService('security');
const PageObjects = getPageObjects(['monitoring', 'timePicker', 'security']);
const noData = getService('monitoringNoData'); const noData = getService('monitoringNoData');
let _archive; let _archive;
@ -33,7 +34,9 @@ export const getLifecycleMethods = (getService, getPageObjects) => {
await PageObjects.timePicker.setAbsoluteRange(from, to); await PageObjects.timePicker.setAbsoluteRange(from, to);
}, },
tearDown() { async tearDown() {
await PageObjects.security.logout();
await security.user.delete('basic_monitoring_user');
return esArchiver.unload(_archive); return esArchiver.unload(_archive);
} }
}; };

2
x-pack/test/functional/apps/monitoring/enable_monitoring/index.js
View file

@ -17,7 +17,7 @@ export default function ({ getService, getPageObjects }) {
before(async () => { before(async () => {
const browser = getService('browser'); const browser = getService('browser');
await browser.setWindowSize(1600, 1000); await browser.setWindowSize(1600, 1000);
await PageObjects.monitoring.navigateTo(); await PageObjects.monitoring.navigateTo(true);
await noData.isOnNoDataPage(); await noData.isOnNoDataPage();
}); });

2
x-pack/test/functional/apps/monitoring/feature_controls/monitoring_security.ts
View file

@ -13,7 +13,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
const appsMenu = getService('appsMenu'); const appsMenu = getService('appsMenu');
const PageObjects = getPageObjects(['common', 'security']); const PageObjects = getPageObjects(['common', 'security']);
describe('securty', () => { describe('security', () => {
before(async () => { before(async () => {
await esArchiver.load('empty_kibana'); await esArchiver.load('empty_kibana');

6
x-pack/test/functional/apps/monitoring/feature_controls/monitoring_spaces.ts
View file

@ -19,6 +19,12 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
await esArchiver.load('empty_kibana'); await esArchiver.load('empty_kibana');
}); });
after(async () => {
await esArchiver.unload('empty_kibana');
await PageObjects.common.navigateToApp('home');
await PageObjects.security.logout();
});
describe('space with no features disabled', () => { describe('space with no features disabled', () => {
before(async () => { before(async () => {
await spacesService.create({ await spacesService.create({

2
x-pack/test/functional/apps/monitoring/index.js
View file

@ -13,7 +13,6 @@ export default function ({ loadTestFile }) {
loadTestFile(require.resolve('./cluster/list')); loadTestFile(require.resolve('./cluster/list'));
loadTestFile(require.resolve('./cluster/overview')); loadTestFile(require.resolve('./cluster/overview'));
loadTestFile(require.resolve('./cluster/alerts')); loadTestFile(require.resolve('./cluster/alerts'));
loadTestFile(require.resolve('./enable_monitoring'));
// loadTestFile(require.resolve('./cluster/license')); // loadTestFile(require.resolve('./cluster/license'));
loadTestFile(require.resolve('./elasticsearch/overview')); loadTestFile(require.resolve('./elasticsearch/overview'));
@ -40,5 +39,6 @@ export default function ({ loadTestFile }) {
loadTestFile(require.resolve('./beats/beat_detail')); loadTestFile(require.resolve('./beats/beat_detail'));
loadTestFile(require.resolve('./time_filter')); loadTestFile(require.resolve('./time_filter'));
loadTestFile(require.resolve('./enable_monitoring'));
}); });
} }

19
x-pack/test/functional/page_objects/monitoring_page.js
View file

@ -5,11 +5,26 @@
*/ */
export function MonitoringPageProvider({ getPageObjects, getService }) { export function MonitoringPageProvider({ getPageObjects, getService }) {
const PageObjects = getPageObjects(['common', 'header']); const PageObjects = getPageObjects(['common', 'header', 'shield', 'spaceSelector']);
const testSubjects = getService('testSubjects'); const testSubjects = getService('testSubjects');
const security = getService('security');
return new class MonitoringPage { return new class MonitoringPage {
async navigateTo() { async navigateTo(useSuperUser = false) {
// always create this because our tear down tries to delete it
await security.user.create('basic_monitoring_user', {
password: 'monitoring_user_password',
roles: ['monitoring_user', 'kibana_user'],
full_name: 'basic monitoring',
});
if (!useSuperUser) {
await PageObjects.common.navigateToApp('login');
await PageObjects.shield.login(
'basic_monitoring_user',
'monitoring_user_password'
);
}
await PageObjects.common.navigateToApp('monitoring'); await PageObjects.common.navigateToApp('monitoring');
} }