github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Response Ops] Remove "Rule" icontypes (#189342)

Browse source 
## Summary
Fixes: https://github.com/elastic/kibana/issues/189212

Removes `rule` icon type, which is invalid, with valid icons

<img width="489" alt="Screenshot 2024-07-29 at 12 41 53 AM"
src="https://github.com/user-attachments/assets/ea5d158b-85ea-4465-83ba-fcb14486dbfa">

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This commit is contained in:
Jiawei Wu 2024-07-31 09:06:24 -06:00 • committed by GitHub
parent cdf5f5c480
commit c73bbc99c4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 53 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

54
x-pack/plugins/triggers_actions_ui/public/application/sections/rule_details/components/rule_details.test.tsx
View file

@ -163,33 +163,43 @@ describe('rule_details', () => {
paddingSize="s"
panelRef={null}
>
<p
className="euiCallOutHeader__title"
>
<EuiIcon
aria-hidden="true"
color="inherit"
css="unknown styles"
size="m"
type="error"
/>
Cannot run rule
</p>
<EuiSpacer
size="s"
/>
<EuiText
color="default"
size="xs"
>
<p>
<EuiIcon
color="danger"
type="warning"
/>
 
<b>
Cannot run rule
</b>
, 
<EuiText
size="xs"
>
test
 
<EuiLink
color="primary"
href="/app/management/stack/license_management"
target="_blank"
>
<MemoizedFormattedMessage
defaultMessage="Manage license"
id="xpack.triggersActionsUI.sections.ruleDetails.manageLicensePlanBannerLinkTitle"
/>
</EuiLink>
</p>
</EuiText>
<EuiSpacer
size="s"
/>
<EuiLink
color="primary"
href="/app/management/stack/license_management"
target="_blank"
>
<MemoizedFormattedMessage
defaultMessage="Manage license"
id="xpack.triggersActionsUI.sections.ruleDetails.manageLicensePlanBannerLinkTitle"
/>
</EuiLink>
</EuiText>
</EuiPanel>
`);

37
x-pack/plugins/triggers_actions_ui/public/application/sections/rule_details/components/rule_details.tsx
View file

@ -465,24 +465,25 @@ export const RuleDetails: React.FunctionComponent<RuleDetailsProps> = ({
rule.executionStatus.error?.reason === RuleExecutionStatusErrorReasons.License ? (
<EuiFlexGroup>
<EuiFlexItem>
<EuiCallOut color="danger" data-test-subj="ruleErrorBanner" size="s" iconType="rule">
<p>
<EuiIcon color="danger" type="warning" />
&nbsp;
<b>{getRuleStatusErrorReasonText()}</b>&#44;&nbsp;
{rule.executionStatus.error?.message}
&nbsp;
<EuiLink
href={`${http.basePath.get()}/app/management/stack/license_management`}
color="primary"
target="_blank"
>
<FormattedMessage
id="xpack.triggersActionsUI.sections.ruleDetails.manageLicensePlanBannerLinkTitle"
defaultMessage="Manage license"
/>
</EuiLink>
</p>
<EuiCallOut
color="danger"
data-test-subj="ruleErrorBanner"
size="s"
iconType="error"
title={getRuleStatusErrorReasonText()}
>
<EuiText size="xs">{rule.executionStatus.error?.message}</EuiText>
<EuiSpacer size="s" />
<EuiLink
href={`${http.basePath.get()}/app/management/stack/license_management`}
color="primary"
target="_blank"
>
<FormattedMessage
id="xpack.triggersActionsUI.sections.ruleDetails.manageLicensePlanBannerLinkTitle"
defaultMessage="Manage license"
/>
</EuiLink>
</EuiCallOut>
</EuiFlexItem>
</EuiFlexGroup>

2
x-pack/plugins/triggers_actions_ui/public/application/sections/rule_form/rule_edit.tsx
View file

@ -270,7 +270,7 @@ export const RuleEdit = <
<EuiCallOut
size="s"
color="danger"
iconType="rule"
iconType="error"
data-test-subj="hasActionsDisabled"
title={i18n.translate(
'xpack.triggersActionsUI.sections.ruleEdit.disabledActionsWarningTitle',

2
x-pack/plugins/triggers_actions_ui/public/application/sections/rules_list/components/rules_list_table.tsx
View file

@ -623,7 +623,7 @@ export const RulesListTable = (props: RulesListTableProps) => {
<EuiIconTip
data-test-subj="ruleDurationWarning"
anchorClassName="ruleDurationWarningIcon"
type="rule"
type="warning"
color="warning"
content={i18n.translate(
'xpack.triggersActionsUI.sections.rulesList.ruleTypeExcessDurationMessage',