[8.x] [Discover] Clean up leftover "saved search" references (#208295) (#208424)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Discover] Clean up leftover "saved search" references
(#208295)](https://github.com/elastic/kibana/pull/208295)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Davis
McPhee","email":"davis.mcphee@elastic.co"},"sourceCommit":{"committedDate":"2025-01-27T18:01:22Z","message":"[Discover]
Clean up leftover \"saved search\" references (#208295)\n\n##
Summary\r\n\r\nI noticed a few remaining user facing references to
\"saved search\" after\r\nthe renaming in #202217. This PR cleans up all
of them that I could\r\nfind.\r\n\r\n### Checklist\r\n\r\n- [ ] Any text
added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\r\n-
[x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] If a plugin
configuration key changed, check if it needs to be\r\nallowlisted in the
cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This was checked for breaking HTTP API changes, and any
breaking\r\nchanges have been approved by the breaking-change committee.
The\r\n`release_note:breaking` label should be applied in these
situations.\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [x] The PR description includes
the appropriate Release Notes section,\r\nand the correct
`release_note:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"665cfe06a658ae87886e3d9ae81b40489b31b67d","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-minor","Project:OneDiscover"],"title":"[Discover]
Clean up leftover \"saved search\"
references","number":208295,"url":"https://github.com/elastic/kibana/pull/208295","mergeCommit":{"message":"[Discover]
Clean up leftover \"saved search\" references (#208295)\n\n##
Summary\r\n\r\nI noticed a few remaining user facing references to
\"saved search\" after\r\nthe renaming in #202217. This PR cleans up all
of them that I could\r\nfind.\r\n\r\n### Checklist\r\n\r\n- [ ] Any text
added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\r\n-
[x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] If a plugin
configuration key changed, check if it needs to be\r\nallowlisted in the
cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This was checked for breaking HTTP API changes, and any
breaking\r\nchanges have been approved by the breaking-change committee.
The\r\n`release_note:breaking` label should be applied in these
situations.\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [x] The PR description includes
the appropriate Release Notes section,\r\nand the correct
`release_note:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"665cfe06a658ae87886e3d9ae81b40489b31b67d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208295","number":208295,"mergeCommit":{"message":"[Discover]
Clean up leftover \"saved search\" references (#208295)\n\n##
Summary\r\n\r\nI noticed a few remaining user facing references to
\"saved search\" after\r\nthe renaming in #202217. This PR cleans up all
of them that I could\r\nfind.\r\n\r\n### Checklist\r\n\r\n- [ ] Any text
added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\r\n-
[x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] If a plugin
configuration key changed, check if it needs to be\r\nallowlisted in the
cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This was checked for breaking HTTP API changes, and any
breaking\r\nchanges have been approved by the breaking-change committee.
The\r\n`release_note:breaking` label should be applied in these
situations.\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [x] The PR description includes
the appropriate Release Notes section,\r\nand the correct
`release_note:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"665cfe06a658ae87886e3d9ae81b40489b31b67d"}}]}]
BACKPORT-->

Co-authored-by: Davis McPhee <davis.mcphee@elastic.co>

docs/discover/save-search.asciidoc

@@ -10,7 +10,7 @@ and can also serve as a foundation for building visualizations.
 [[discover-read-only-access]]
 [float]
 === Read-only access
-If you don't have sufficient privileges to save searches, the following indicator is
+If you don't have sufficient privileges to save Discover sessions, the following indicator is
 displayed and the *Save* button is not visible. For more information, refer to <<xpack-security-authorization>>.
 
 [role="screenshot"]

docs/discover/search.asciidoc

@@ -100,7 +100,7 @@ A Discover session includes the query text, filters, and optionally, the time fi
 [role="xpack"]
 [[discover-read-only-access]]
 ==== Read-only access
-When you have insufficient privileges to save searches, the following indicator in Kibana will be
+When you have insufficient privileges to save Discover sessions, the following indicator in Kibana will be
 displayed and the *Save* button won't be visible. For more information on granting access to
 Kibana see <<xpack-security-authorization>>.
 

docs/user/discover.asciidoc

@@ -11,7 +11,7 @@ What processes take longer than 500 milliseconds to respond?
 [[save-your-search]]
 With *Discover*, you can quickly search and filter your data, get information
 about the structure of the fields, and display your findings in a visualization.
-You can also customize and save your searches and place them on a dashboard.
+You can also customize and save your Discover sessions and place them on a dashboard.
 
 [role="screenshot"]
 image::images/hello-field.png[A view of the Discover app]

src/platform/plugins/private/vis_default_editor/public/components/sidebar/sidebar_title.tsx

@@ -127,7 +127,7 @@ export function LinkedSearch({ savedSearch, eventEmitter }: LinkedSearchProps) {
                 >
                   <FormattedMessage
                     id="visDefaultEditor.sidebar.savedSearch.goToDiscoverButtonText"
-                    defaultMessage="View this search in Discover"
+                    defaultMessage="View this session in Discover"
                   />
                 </EuiButtonEmpty>
               </p>

src/platform/plugins/shared/discover/public/application/main/components/top_nav/on_save_search.tsx

@@ -262,7 +262,7 @@ const SaveSearchObjectModal: React.FC<{
       helpText={
         <FormattedMessage
           id="discover.topNav.saveModal.storeTimeWithSearchToggleDescription"
-          defaultMessage="Update the time filter and refresh interval to the current selection when using this search."
+          defaultMessage="Update the time filter and refresh interval to the current selection when using this session."
         />
       }
     >

src/platform/plugins/shared/saved_search/common/service/get_saved_searches.test.ts

@@ -42,7 +42,7 @@ describe('getSavedSearch', () => {
     }
 
     expect(errorMessage).toBe(
-      'Could not locate that search (id: ccf1af80-2297-11ec-86e0-1155ffb9c7a7)'
+      'Could not locate that Discover session (id: ccf1af80-2297-11ec-86e0-1155ffb9c7a7)'
     );
   });
 

src/platform/plugins/shared/saved_search/common/service/get_saved_searches.ts

@@ -28,7 +28,7 @@ export interface GetSavedSearchDependencies {
 
 const getSavedSearchUrlConflictMessage = async (json: string) =>
   i18n.translate('savedSearch.legacyURLConflict.errorMessage', {
-    defaultMessage: `This search has the same URL as a legacy alias. Disable the alias to resolve this error : {json}`,
+    defaultMessage: `This Discover session has the same URL as a legacy alias. Disable the alias to resolve this error : {json}`,
     values: { json },
   });
 
@@ -40,7 +40,7 @@ export const getSearchSavedObject = async (
 
   // @ts-expect-error
   if (so.error) {
-    throw new Error(`Could not locate that search (id: ${savedSearchId})`);
+    throw new Error(`Could not locate that Discover session (id: ${savedSearchId})`);
   }
 
   if (so.meta.outcome === 'conflict') {