github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Discover] Fix saved search embeddable rendering (#140264)

Browse source 
* [Discover] fix rendering issue

* [Discover] add functional test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Dmitry Tomashevich 2022-09-12 12:58:16 +03:00 • committed by GitHub
parent 757ddcbbad
commit c80de81964
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 24 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/plugins/discover/public/embeddable/saved_search_embeddable.tsx
View file

@ -484,6 +484,8 @@ export class SavedSearchEmbeddable
ReactDOM.unmountComponentAtNode(this.node);
}
this.node = domNode;
this.renderReactComponent(this.node, this.searchProps!);
}
private renderReactComponent(domNode: HTMLElement, searchProps: SearchProps) {

10
test/functional/apps/discover/embeddable/_saved_search_embeddable.ts
View file

@ -77,5 +77,15 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await dataGrid.checkCurrentRowsPerPageToBe(10);
});
it('should render duplicate saved search embeddables', async () => {
await PageObjects.dashboard.switchToEditMode();
await addSearchEmbeddableToDashboard();
const [firstGridCell, secondGridCell] = await dataGrid.getAllCellElements();
const firstGridCellContent = await firstGridCell.getVisibleText();
const secondGridCellContent = await secondGridCell.getVisibleText();
expect(firstGridCellContent).to.be.equal(secondGridCellContent);
});
});
}

15
test/functional/services/data_grid.ts
View file

@ -80,15 +80,24 @@ export class DataGridService extends FtrService {
.map((cell) => $(cell).text());
}
private getCellElementSelector(rowIndex: number = 0, columnIndex: number = 0) {
return `[data-test-subj="euiDataGridBody"] [data-test-subj="dataGridRowCell"][data-gridcell-column-index="${columnIndex}"][data-gridcell-row-index="${rowIndex}"]`;
}
/**
* Returns a grid cell element by row & column indexes.
* @param rowIndex data row index starting from 0 (0 means 1st row)
* @param columnIndex column index starting from 0 (0 means 1st column)
*/
public async getCellElement(rowIndex: number = 0, columnIndex: number = 0) {
return await this.find.byCssSelector(
`[data-test-subj="euiDataGridBody"] [data-test-subj="dataGridRowCell"][data-gridcell-column-index="${columnIndex}"][data-gridcell-row-index="${rowIndex}"]`
);
return await this.find.byCssSelector(this.getCellElementSelector(rowIndex, columnIndex));
}
/**
* The same as getCellElement, but useful when multiple data grids are on the page.
*/
public async getAllCellElements(rowIndex: number = 0, columnIndex: number = 0) {
return await this.find.allByCssSelector(this.getCellElementSelector(rowIndex, columnIndex));
}
public async getDocCount(): Promise<number> {