github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-06-28 03:01:21 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Infra UI] Test fix: add retry to metadata remove pin button check after refresh (#161736)

Browse source 
Closes #161514

## Summary

This PR fixes the flyout test, it seems there was a timeout before the
check (in the screenshot is visible that the button is there so could be
that the check happened before the loading finished) I added a retry
there.
This commit is contained in:
jennypavlova 2023-07-13 12:13:53 +02:00 • committed by GitHub
parent 5b89675835
commit c8a451e45a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

10
x-pack/test/functional/apps/infra/hosts_view.ts
View file

@ -154,8 +154,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
return !!currentUrl.match(path); return !!currentUrl.match(path);
}); });
// Failing: See https://github.com/elastic/kibana/issues/161514 describe('Hosts View', function () {
describe.skip('Hosts View', function () {
before(async () => { before(async () => {
await Promise.all([ await Promise.all([
esArchiver.load('x-pack/test/functional/es_archives/infra/alerts'), esArchiver.load('x-pack/test/functional/es_archives/infra/alerts'),
@ -309,8 +308,11 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
// Persist pin after refresh // Persist pin after refresh
await browser.refresh(); await browser.refresh();
await pageObjects.infraHome.waitForLoading(); await retry.try(async () => {
expect(await pageObjects.infraHostsView.getRemovePinExist()).to.be(true); await pageObjects.infraHome.waitForLoading();
const removePinExist = await pageObjects.infraHostsView.getRemovePinExist();
expect(removePinExist).to.be(true);
});
// Remove Pin // Remove Pin
await pageObjects.infraHostsView.clickRemoveMetadataPin(); await pageObjects.infraHostsView.clickRemoveMetadataPin();