mirror of
https://github.com/elastic/kibana.git
synced 2025-04-24 01:38:56 -04:00
[Rules migration] Allow partial RuleResponse
object to be passed to RuleOverviewTab
(#204318)
## Summary These changes allow `Partial<RuleResponse>` to be used as a parameter for `RuleOverviewTab` component. We re-use this component for "SIEM Migrations" feature to display translated state of the rule which has just a few fields that represent the `RuleResponse` object. The set of fields used in `RuleMigration` object is a minimum set of fields enough for the rule creation. Right now, `RuleOverviewTab` component requires the complete `RuleResponse` object to be passed even though internally each section (`RuleAboutSection`, `RuleDefinitionSection`, `RuleScheduleSection` and `RuleSetupGuideSection`) of the rule's overview expects `Partial<RuleResponse>`. To be able to use this component we force type casting at the moment and would like to get rid of it. @elastic/security-detection-rule-management do you have objects regarding this change in `RuleOverviewTab` intefrace? ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - Rule management cypress tests ([100 ESS & 100 Serverless](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7601))
This commit is contained in:
parent
73066e8cc3
commit
c92899e142
2 changed files with 2 additions and 2 deletions
|
@ -88,7 +88,7 @@ const ExpandableSection = ({ title, isOpen, toggle, children }: ExpandableSectio
|
|||
};
|
||||
|
||||
interface RuleOverviewTabProps {
|
||||
rule: RuleResponse;
|
||||
rule: Partial<RuleResponse>;
|
||||
columnWidths?: EuiDescriptionListProps['columnWidths'];
|
||||
expandedOverviewSections: Record<keyof typeof defaultOverviewOpenSections, boolean>;
|
||||
toggleOverviewSection: Record<keyof typeof defaultOverviewOpenSections, () => void>;
|
||||
|
|
|
@ -126,7 +126,7 @@ export const MigrationRuleDetailsFlyout: React.FC<MigrationRuleDetailsFlyoutProp
|
|||
const ruleDetailsToOverview = useMemo(() => {
|
||||
const elasticRule = ruleMigration?.elastic_rule;
|
||||
if (isMigrationCustomRule(elasticRule)) {
|
||||
return convertMigrationCustomRuleToSecurityRulePayload(elasticRule, false) as RuleResponse; // TODO: we need to adjust RuleOverviewTab to allow partial RuleResponse as a parameter;
|
||||
return convertMigrationCustomRuleToSecurityRulePayload(elasticRule, false);
|
||||
}
|
||||
return matchedPrebuiltRule;
|
||||
}, [ruleMigration, matchedPrebuiltRule]);
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue