github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Enterprise Search][Behavioral Analytics] Add validation for collection name (#156824)

Browse source 
Use validation for creationg collection name. Allowed only lowercase
letters, numbers and hyphens
<img width="686" alt="image"
src="https://user-images.githubusercontent.com/17390745/236435878-bc3e2e04-2e22-4572-a55a-c78c5727016b.png">
This commit is contained in:
Yan Savitski 2023-05-05 14:14:08 +02:00 • committed by GitHub
parent eda3c85bb4
commit cab27d3e21
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 27 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

14
x-pack/plugins/enterprise_search/public/applications/analytics/components/add_analytics_collections/add_analytics_collection_logic.test.ts
View file

@ -151,6 +151,20 @@ describe('addAnalyticsCollectionLogic', () => {
});
});
});
describe('setNameValue', () => {
it('should call an error if name is not valid', () => {
AddAnalyticsCollectionLogic.actions.setNameValue('Invalid');
expect(AddAnalyticsCollectionLogic.values.inputError).toBeTruthy();
});
it('should remove error if name become valid', () => {
AddAnalyticsCollectionLogic.actions.setNameValue('Invalid');
expect(AddAnalyticsCollectionLogic.values.inputError).toBeTruthy();
AddAnalyticsCollectionLogic.actions.setNameValue('valid');
expect(AddAnalyticsCollectionLogic.values.inputError).toBeFalsy();
});
});
});
describe('selectors', () => {

15
x-pack/plugins/enterprise_search/public/applications/analytics/components/add_analytics_collections/add_analytics_collection_logic.ts
View file

@ -27,6 +27,7 @@ import {
import { COLLECTION_OVERVIEW_PATH } from '../../routes';
const SERVER_ERROR_CODE = 500;
const NAME_VALIDATION = new RegExp(/^[a-z0-9\-]+$/);
export interface AddAnalyticsCollectionsActions {
apiError: Actions<
@ -111,6 +112,16 @@ export const AddAnalyticsCollectionLogic = kea<
const { name } = values;
actions.makeRequest({ name });
},
setNameValue: ({ name }) => {
if (!NAME_VALIDATION.test(name)) {
actions.setInputError(
i18n.translate('xpack.enterpriseSearch.analytics.collectionsCreate.invalidName', {
defaultMessage:
'Collection name can only contain lowercase letters, numbers, and hyphens',
})
);
}
},
}),
path: ['enterprise_search', 'analytics', 'add_analytics_collection'],
reducers: {
@ -130,8 +141,8 @@ export const AddAnalyticsCollectionLogic = kea<
},
selectors: ({ selectors }) => ({
canSubmit: [
() => [selectors.isLoading, selectors.name],
(isLoading, name) => !isLoading && name.length > 0,
() => [selectors.isLoading, selectors.name, selectors.inputError],
(isLoading, name, inputError) => !isLoading && name.length > 0 && !inputError,
],
isLoading: [() => [selectors.status], (status: Status) => status === Status.LOADING],
isSuccess: [() => [selectors.status], (status: Status) => status === Status.SUCCESS],