github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

Guard against calling fieldWildcardMatcher or fieldWildcardFilter with undefined (#19865) (#19906)

Browse source
This commit is contained in:
CJ Cenizal 2018-06-14 10:52:50 -07:00 • committed by GitHub
parent 55a60ab11f
commit cbc1dee01d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/ui/public/field_wildcard/__tests__/field_wildcard.js
View file

@ -57,6 +57,18 @@ describe('fieldWildcard', function () {
});
describe('filter', function () {
it('filters nothing when given undefined', function () {
const filter = fieldWildcardFilter();
const original = [
'foo',
'bar',
'baz',
1234
];
expect(original.filter(filter)).to.eql(original);
});
it('filters nothing when given an empty array', function () {
const filter = fieldWildcardFilter([]);
const original = [

6
src/ui/public/field_wildcard/field_wildcard.js
View file

@ -26,7 +26,8 @@ export function FieldWildcardProvider(config) {
return new RegExp('^' + glob.split('*').map(escapeRegExp).join('.*') + '$');
});
function fieldWildcardMatcher(globs) {
// Note that this will return an essentially noop function if globs is undefined.
function fieldWildcardMatcher(globs = []) {
return function matcher(val) {
// do not test metaFields or keyword
if (metaFields.indexOf(val) !== -1) {
@ -36,7 +37,8 @@ export function FieldWildcardProvider(config) {
};
}
function fieldWildcardFilter(globs) {
// Note that this will return an essentially noop function if globs is undefined.
function fieldWildcardFilter(globs = []) {
const matcher = fieldWildcardMatcher(globs);
return function filter(val) {
return !matcher(val);