github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-06-28 19:13:14 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Discover] Unskip functional discover request counts test and skip ES|QL part (#205690)

Browse source 
Unskipping the main test, and unskipping the `ES|QL` part due to flakiness
This commit is contained in:
Matthias Wilhelm 2025-01-09 06:35:40 +01:00 • committed by GitHub
parent 7a63ae2e4c
commit cbcb24e036
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 31 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

17
test/functional/apps/discover/group3/_request_counts.ts
View file

@ -28,8 +28,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const log = getService('log'); const log = getService('log');
const retry = getService('retry'); const retry = getService('retry');
// Failing: See https://github.com/elastic/kibana/issues/205344 describe('discover request counts', function describeIndexTests() {
describe.skip('discover request counts', function describeIndexTests() {
before(async function () { before(async function () {
await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/logstash_functional'); await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/logstash_functional');
await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/long_window_logstash'); await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/long_window_logstash');
@ -54,7 +53,9 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
}); });
const expectSearchCount = async (type: 'ese' | 'esql', searchCount: number) => { const expectSearchCount = async (type: 'ese' | 'esql', searchCount: number) => {
await retry.try(async () => { await retry.tryWithRetries(
`expect ${type} request to match count ${searchCount}`,
async () => {
if (searchCount === 0) { if (searchCount === 0) {
await browser.execute(async () => { await browser.execute(async () => {
performance.clearResourceTimings(); performance.clearResourceTimings();
@ -77,7 +78,9 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
log.warning('Request count differs:', result); log.warning('Request count differs:', result);
} }
expect(count).to.be(searchCount); expect(count).to.be(searchCount);
}); },
{ retryCount: 5, retryDelay: 500 }
);
}; };
const waitForLoadingToFinish = async () => { const waitForLoadingToFinish = async () => {
@ -257,8 +260,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
}); });
}); });
}); });
// Currently ES|QL checks are disabled due to various flakiness
describe('ES|QL mode', () => { // Note that ES|QL also checks for different number of requests due to the fields request triggered
// by the ES|QL Editor
describe.skip('ES|QL mode', () => {
const type = 'esql'; const type = 'esql';
before(async () => { before(async () => {
await common.navigateToApp('discover'); await common.navigateToApp('discover');