github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

[es/versionCheck] clarify new var and reason for check

Browse source
This commit is contained in:
spalger 2016-10-27 15:36:43 -07:00
parent bb95cf874c
commit cda9594859
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/core_plugins/elasticsearch/lib/check_es_version.js
View file

@ -9,7 +9,9 @@ import semver from 'semver';
import isEsCompatibleWithKibana from './is_es_compatible_with_kibana';
import SetupError from './setup_error';
const lastWarnedAboutNodes = new WeakMap();
// tracks the node descriptions that get logged in warnings so
// that we don't spam the log with the same message over and over
const lastWarnedNodesForServer = new WeakMap();
module.exports = function checkEsVersion(server, kibanaVersion) {
server.log(['plugin', 'debug'], 'Checking Elasticsearch version');
@ -52,9 +54,10 @@ module.exports = function checkEsVersion(server, kibanaVersion) {
ip: node.ip,
}));
// Don't show the same warning over and over again.
const warningNodeNames = getHumanizedNodeNames(simplifiedNodes).join(', ');
if (lastWarnedAboutNodes.get(server) !== warningNodeNames) {
lastWarnedAboutNodes.set(server, warningNodeNames);
if (lastWarnedNodesForServer.get(server) !== warningNodeNames) {
lastWarnedNodesForServer.set(server, warningNodeNames);
server.log(['warning'], {
tmpl: (
`You're running Kibana ${kibanaVersion} with some newer versions of ` +