github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

Controls vis - safely handle case where value can not be extracted from Kibana filter (#22885) (#22900)

Browse source 
* handle case where value can not be extracted from Kibana filter

* review feedback
This commit is contained in:
Nathan Reese 2018-09-10 15:58:03 -06:00 • committed by GitHub
parent c74da9cac9
commit cf95d1d6b8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 43 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/core_plugins/input_control_vis/public/control/filter_manager/phrase_filter_manager.js
View file

@ -61,10 +61,17 @@ export class PhraseFilterManager extends FilterManager {
return;
}
return kbnFilters
const values = kbnFilters
.map((kbnFilter) => {
return this._getValueFromFilter(kbnFilter);
})
.filter(value => value != null);
if (values.length === 0) {
return;
}
return values
.reduce((accumulator, currentValue) => {
return accumulator.concat(currentValue);
}, [])

16
src/core_plugins/input_control_vis/public/control/filter_manager/phrase_filter_manager.test.js
View file

@ -154,6 +154,22 @@ describe('PhraseFilterManager', function () {
]);
expect(filterManager.getValueFromFilterBar()).to.eql([{ value: 'ios', label: 'ios' }, { value: 'win xp', label: 'win xp' }]);
});
test('should return undefined when filter value can not be extracted from Kibana filter', function () {
filterManager.setMockFilters([
{
query: {
match: {
myFieldWhichIsNotField1: {
query: 'ios',
type: 'phrase'
}
}
}
}
]);
expect(filterManager.getValueFromFilterBar()).to.eql(undefined);
});
});
});

7
src/core_plugins/input_control_vis/public/control/filter_manager/range_filter_manager.js
View file

@ -69,14 +69,17 @@ export class RangeFilterManager extends FilterManager {
return;
}
let range = null;
let range;
if (_.has(kbnFilters[0], 'script')) {
range = _.get(kbnFilters[0], 'script.script.params');
} else {
range = _.get(kbnFilters[0], ['range', this.fieldName]);
}
return fromRange(range);
if (!range) {
return;
}
return fromRange(range);
}
}

14
src/core_plugins/input_control_vis/public/control/filter_manager/range_filter_manager.test.js
View file

@ -91,6 +91,20 @@ describe('RangeFilterManager', function () {
expect(value).to.have.property('max');
expect(value.max).to.be(3);
});
test('should return undefined when filter value can not be extracted from Kibana filter', function () {
filterManager.setMockFilters([
{
range: {
myFieldWhichIsNotField1: {
gte: 1,
lte: 3
}
}
}
]);
expect(filterManager.getValueFromFilterBar()).to.eql(undefined);
});
});
});