github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-25 02:09:32 -04:00
Code Issues Projects Releases Packages Wiki Activity

redirect to visualize listing page when by value visualization editor doesn't have a value input (#84287) (#84345)

Browse source
This commit is contained in:
Devon Thomson 2020-11-25 12:51:14 -05:00 • committed by GitHub
parent dfc0123247
commit cfbb5e97d0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/plugins/visualize/public/application/components/visualize_byvalue_editor.tsx
View file

@ -33,6 +33,7 @@ import {
import { VisualizeServices } from '../types'; import { VisualizeServices } from '../types';
import { VisualizeEditorCommon } from './visualize_editor_common'; import { VisualizeEditorCommon } from './visualize_editor_common';
import { VisualizeAppProps } from '../app'; import { VisualizeAppProps } from '../app';
import { VisualizeConstants } from '../..';
export const VisualizeByValueEditor = ({ onAppLeave }: VisualizeAppProps) => { export const VisualizeByValueEditor = ({ onAppLeave }: VisualizeAppProps) => {
const [originatingApp, setOriginatingApp] = useState<string>(); const [originatingApp, setOriginatingApp] = useState<string>();
@ -52,7 +53,8 @@ export const VisualizeByValueEditor = ({ onAppLeave }: VisualizeAppProps) => {
setValueInput(valueInputValue); setValueInput(valueInputValue);
setEmbeddableId(embeddableIdValue); setEmbeddableId(embeddableIdValue);
if (!valueInputValue) { if (!valueInputValue) {
history.back(); // if there is no value input to load, redirect to the visualize listing page.
services.history.replace(VisualizeConstants.LANDING_PAGE_PATH);
} }
}, [services]); }, [services]);