github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-06-27 18:51:07 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Guided onboarding] Fix the missing help link (#156399)

Browse source 
## Summary

This PR fixes a bug introduced in
https://github.com/elastic/kibana/pull/155065/ that I noticed when
testing guided onboarding for v8.9.0: the help link was missing from the
help menu. I added a functional test for the help link but we also need
a test that the link is hidden when the user doesn't have access to
guided onboarding (opened an issue for that
[here](https://github.com/elastic/kibana/issues/156410)).

### How to test
1. Add xpack.cloud.id: 'testID' to /config/kibana.dev.yml
2. Start ES with yarn es snapshot and Kibana with `yarn start``
3. Check that the help link "Setup guides" is displayed in the help menu

### Screenshot 
<img width="336" alt="Screenshot 2023-05-02 at 17 27 20"
src="https://user-images.githubusercontent.com/6585477/235712599-812b422d-3092-45b3-a726-37f6b90e81c1.png">
This commit is contained in:
Yulia Čech 2023-05-03 16:00:09 +02:00 • committed by GitHub
parent b6ea07ac24
commit d00e2a366f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
x-pack/plugins/cloud_integrations/cloud_links/kibana.jsonc
View file

@ -10,7 +10,7 @@
"optionalPlugins": [ "optionalPlugins": [
"cloud", "cloud",
"security", "security",
"guided_onboarding" "guidedOnboarding"
] ]
} }
} }

20
x-pack/test/functional_cloud/tests/cloud_links.ts
View file

@ -30,10 +30,22 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.header.waitUntilLoadingHasFinished(); await PageObjects.header.waitUntilLoadingHasFinished();
}); });
it('The button "Setup guides" is loaded', async () => { describe('Guided onboarding', () => {
expect(await find.byCssSelector('[data-test-subj="guideButtonRedirect"]')).to.not.be(null); it('The button "Setup guides" is loaded', async () => {
const cloudLink = await find.byLinkText('Setup guides'); expect(await find.byCssSelector('[data-test-subj="guideButtonRedirect"]')).to.not.be(null);
expect(cloudLink).to.not.be(null); const cloudLink = await find.byLinkText('Setup guides');
expect(cloudLink).to.not.be(null);
});
it('The help link "Setup guides" is added', async () => {
await PageObjects.common.clickAndValidate(
'helpMenuButton',
'cloudOnboardingSetupGuideLink'
);
expect(
await find.byCssSelector('[data-test-subj="cloudOnboardingSetupGuideLink"]')
).to.not.be(null);
});
}); });
it('"Manage this deployment" is appended to the nav list', async () => { it('"Manage this deployment" is appended to the nav list', async () => {