github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Lens] revert Select line chart by default if the x-axis contains a timestamp (#198555)

Browse source 
Reverts https://github.com/elastic/kibana/pull/190786/files

---------

Co-authored-by: Marco Vettorello <marco.vettorello@elastic.co>
This commit is contained in:
Marta Bondyra 2024-11-04 15:25:07 +01:00 • committed by GitHub
parent 5721de74ce
commit d1171418dd
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 6 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

6
x-pack/plugins/lens/public/visualizations/xy/xy_suggestions.test.ts
View file

@ -854,7 +854,7 @@ describe('xy_suggestions', () => {
expect((suggestions[0].state.layers[0] as XYDataLayerConfig).seriesType).toEqual('line');
});
test('suggests line if changeType is initial and date column is involved', () => {
test('suggests bar if changeType is initial and date column is involved', () => {
const currentState: XYState = {
legend: { isVisible: true, position: 'bottom' },
valueLabels: 'hide',
@ -885,8 +885,8 @@ describe('xy_suggestions', () => {
expect(suggestions).toHaveLength(1);
expect(suggestions[0].hide).toEqual(false);
expect(suggestions[0].state.preferredSeriesType).toEqual('line');
expect((suggestions[0].state.layers[0] as XYDataLayerConfig).seriesType).toEqual('line');
expect(suggestions[0].state.preferredSeriesType).toEqual('bar_stacked');
expect((suggestions[0].state.layers[0] as XYDataLayerConfig).seriesType).toEqual('bar_stacked');
});
test('makes a visible seriesType suggestion for unchanged table without split', () => {

3
x-pack/plugins/lens/public/visualizations/xy/xy_suggestions.ts
View file

@ -233,9 +233,6 @@ function getSuggestionsForLayer({
allowMixed,
};
if (changeType === 'initial' && xValue?.operation.dataType === 'date') {
return buildSuggestion({ ...options, seriesType: 'line' });
}
// handles the simplest cases, acting as a chart switcher
if (!currentState && changeType === 'unchanged') {
// Chart switcher needs to include every chart type

6
x-pack/test/functional/apps/lens/group1/multiple_data_views.ts
View file

@ -103,13 +103,13 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await testSubjects.click('fieldToggle-DistanceKilometers');
const data = await lens.getCurrentChartDebugState('xyVisChart');
assertMatchesExpectedData(data, [expectedLogstashData, expectedFlightsData], 'lines');
assertMatchesExpectedData(data, [expectedLogstashData, expectedFlightsData]);
});
it('ignores global filters on layers using a data view without the filter field', async () => {
await filterBar.addFilter({ field: 'Carrier', operation: 'exists' });
const data = await lens.getCurrentChartDebugState('xyVisChart');
assertMatchesExpectedData(data, [expectedLogstashData, expectedFlightsData], 'lines');
assertMatchesExpectedData(data, [expectedLogstashData, expectedFlightsData]);
await lens.save(visTitle);
});
@ -120,7 +120,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await visualize.openSavedVisualization(visTitle);
const data = await lens.getCurrentChartDebugState('xyVisChart');
assertMatchesExpectedData(data, [expectedFlightsData], 'lines');
assertMatchesExpectedData(data, [expectedFlightsData]);
});
});
}