github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

[AO] Set the Custom Threshold ONLY available on stateful as Tech Preview (#167782)

Browse source 
## Summary
It fixes https://github.com/elastic/kibana/issues/167650
This commit is contained in:
Faisal Kanout 2023-10-02 20:34:16 +03:00 • committed by GitHub
parent ea33696ba7
commit d28227ca6a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
15 changed files with 19 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

2
test/plugin_functional/test_suites/core_plugins/rendering.ts
View file

@ -298,7 +298,7 @@ export default function ({ getService }: PluginFunctionalProviderContext) {
'xpack.observability.unsafe.alertDetails.logs.enabled (boolean)',
'xpack.observability.unsafe.alertDetails.uptime.enabled (boolean)',
'xpack.observability.unsafe.alertDetails.observability.enabled (boolean)',
'xpack.observability.unsafe.thresholdRule.enabled (boolean)',
'xpack.observability.unsafe.thresholdRule.enabled (any)', // conditional, is actually a boolean
'xpack.observability_onboarding.ui.enabled (boolean)',
'xpack.observabilityLogExplorer.navigation.showAppLink (any)', // conditional, is actually a boolean
];

2
x-pack/plugins/observability/public/components/custom_threshold/mocks/metric_threshold_rule.ts
View file

@ -159,7 +159,7 @@ export const buildMetricThresholdAlert = (
alertOnGroupDisappear: true,
},
'kibana.alert.evaluation.values': [2500, 5],
'kibana.alert.rule.category': 'Custom threshold (BETA)',
'kibana.alert.rule.category': 'Custom threshold (Technical Preview)',
'kibana.alert.rule.consumer': 'alerts',
'kibana.alert.rule.execution.uuid': '62dd07ef-ead9-4b1f-a415-7c83d03925f7',
'kibana.alert.rule.name': 'One condition',

7
x-pack/plugins/observability/server/index.ts
View file

@ -8,7 +8,7 @@
// TODO: https://github.com/elastic/kibana/issues/110905
/* eslint-disable @kbn/eslint/no_export_all */
import { schema, TypeOf } from '@kbn/config-schema';
import { offeringBasedSchema, schema, TypeOf } from '@kbn/config-schema';
import { PluginConfigDescriptor, PluginInitializerContext } from '@kbn/core/server';
import { ObservabilityPlugin, ObservabilityPluginSetup } from './plugin';
import { createOrUpdateIndex, Mappings } from './utils/create_or_update_index';
@ -47,7 +47,10 @@ const configSchema = schema.object({
}),
}),
thresholdRule: schema.object({
enabled: schema.boolean({ defaultValue: true }),
enabled: offeringBasedSchema({
serverless: schema.boolean({ defaultValue: false }),
traditional: schema.boolean({ defaultValue: true }),
}),
}),
}),
customThresholdRule: schema.object({

2
x-pack/plugins/observability/server/lib/rules/custom_threshold/register_custom_threshold_rule_type.ts
View file

@ -121,7 +121,7 @@ export function thresholdRuleType(
return {
id: OBSERVABILITY_THRESHOLD_RULE_TYPE_ID,
name: i18n.translate('xpack.observability.threshold.ruleName', {
defaultMessage: 'Custom threshold (BETA)',
defaultMessage: 'Custom threshold (Technical Preview)',
}),
validate: {
params: schema.object(

2
x-pack/test/alerting_api_integration/observability/custom_threshold_rule/avg_pct_fired.ts
View file

@ -143,7 +143,7 @@ export default function ({ getService }: FtrProviderContext) {
expect(resp.hits.hits[0]._source).property(
'kibana.alert.rule.category',
'Custom threshold (BETA)'
'Custom threshold (Technical Preview)'
);
expect(resp.hits.hits[0]._source).property('kibana.alert.rule.consumer', 'logs');
expect(resp.hits.hits[0]._source).property('kibana.alert.rule.name', 'Threshold rule');

2
x-pack/test/alerting_api_integration/observability/custom_threshold_rule/avg_pct_no_data.ts
View file

@ -134,7 +134,7 @@ export default function ({ getService }: FtrProviderContext) {
expect(resp.hits.hits[0]._source).property(
'kibana.alert.rule.category',
'Custom threshold (BETA)'
'Custom threshold (Technical Preview)'
);
expect(resp.hits.hits[0]._source).property('kibana.alert.rule.consumer', 'logs');
expect(resp.hits.hits[0]._source).property('kibana.alert.rule.name', 'Threshold rule');

2
x-pack/test/alerting_api_integration/observability/custom_threshold_rule/avg_us_fired.ts
View file

@ -160,7 +160,7 @@ export default function ({ getService }: FtrProviderContext) {
expect(resp.hits.hits[0]._source).property(
'kibana.alert.rule.category',
'Custom threshold (BETA)'
'Custom threshold (Technical Preview)'
);
expect(resp.hits.hits[0]._source).property('kibana.alert.rule.consumer', 'logs');
expect(resp.hits.hits[0]._source).property('kibana.alert.rule.name', 'Threshold rule');

2
x-pack/test/alerting_api_integration/observability/custom_threshold_rule/custom_eq_avg_bytes_fired.ts
View file

@ -151,7 +151,7 @@ export default function ({ getService }: FtrProviderContext) {
expect(resp.hits.hits[0]._source).property(
'kibana.alert.rule.category',
'Custom threshold (BETA)'
'Custom threshold (Technical Preview)'
);
expect(resp.hits.hits[0]._source).property('kibana.alert.rule.consumer', 'logs');
expect(resp.hits.hits[0]._source).property('kibana.alert.rule.name', 'Threshold rule');

2
x-pack/test/alerting_api_integration/observability/custom_threshold_rule/documents_count_fired.ts
View file

@ -141,7 +141,7 @@ export default function ({ getService }: FtrProviderContext) {
expect(resp.hits.hits[0]._source).property(
'kibana.alert.rule.category',
'Custom threshold (BETA)'
'Custom threshold (Technical Preview)'
);
expect(resp.hits.hits[0]._source).property('kibana.alert.rule.consumer', 'logs');
expect(resp.hits.hits[0]._source).property('kibana.alert.rule.name', 'Threshold rule');

2
x-pack/test/alerting_api_integration/observability/custom_threshold_rule/group_by_fired.ts
View file

@ -164,7 +164,7 @@ export default function ({ getService }: FtrProviderContext) {
expect(resp.hits.hits[0]._source).property(
'kibana.alert.rule.category',
'Custom threshold (BETA)'
'Custom threshold (Technical Preview)'
);
expect(resp.hits.hits[0]._source).property('kibana.alert.rule.consumer', 'logs');
expect(resp.hits.hits[0]._source).property('kibana.alert.rule.name', 'Threshold rule');

2
x-pack/test_serverless/api_integration/test_suites/observability/custom_threshold_rule/avg_pct_fired.ts
View file

@ -145,7 +145,7 @@ export default function ({ getService }: FtrProviderContext) {
expect(resp.hits.hits[0]._source).property(
'kibana.alert.rule.category',
'Custom threshold (BETA)'
'Custom threshold (Technical Preview)'
);
expect(resp.hits.hits[0]._source).property('kibana.alert.rule.consumer', 'apm');
expect(resp.hits.hits[0]._source).property('kibana.alert.rule.name', 'Threshold rule');

2
x-pack/test_serverless/api_integration/test_suites/observability/custom_threshold_rule/avg_pct_no_data.ts
View file

@ -131,7 +131,7 @@ export default function ({ getService }: FtrProviderContext) {
expect(resp.hits.hits[0]._source).property(
'kibana.alert.rule.category',
'Custom threshold (BETA)'
'Custom threshold (Technical Preview)'
);
expect(resp.hits.hits[0]._source).property('kibana.alert.rule.consumer', 'apm');
expect(resp.hits.hits[0]._source).property('kibana.alert.rule.name', 'Threshold rule');

2
x-pack/test_serverless/api_integration/test_suites/observability/custom_threshold_rule/custom_eq_avg_bytes_fired.ts
View file

@ -149,7 +149,7 @@ export default function ({ getService }: FtrProviderContext) {
expect(resp.hits.hits[0]._source).property(
'kibana.alert.rule.category',
'Custom threshold (BETA)'
'Custom threshold (Technical Preview)'
);
expect(resp.hits.hits[0]._source).property('kibana.alert.rule.consumer', 'apm');
expect(resp.hits.hits[0]._source).property('kibana.alert.rule.name', 'Threshold rule');

2
x-pack/test_serverless/api_integration/test_suites/observability/custom_threshold_rule/documents_count_fired.ts
View file

@ -139,7 +139,7 @@ export default function ({ getService }: FtrProviderContext) {
expect(resp.hits.hits[0]._source).property(
'kibana.alert.rule.category',
'Custom threshold (BETA)'
'Custom threshold (Technical Preview)'
);
expect(resp.hits.hits[0]._source).property('kibana.alert.rule.consumer', 'apm');
expect(resp.hits.hits[0]._source).property('kibana.alert.rule.name', 'Threshold rule');

2
x-pack/test_serverless/api_integration/test_suites/observability/custom_threshold_rule/group_by_fired.ts
View file

@ -158,7 +158,7 @@ export default function ({ getService }: FtrProviderContext) {
expect(resp.hits.hits[0]._source).property(
'kibana.alert.rule.category',
'Custom threshold (BETA)'
'Custom threshold (Technical Preview)'
);
expect(resp.hits.hits[0]._source).property('kibana.alert.rule.consumer', 'apm');
expect(resp.hits.hits[0]._source).property('kibana.alert.rule.name', 'Threshold rule');