github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[8.18] [Inference] Updating link text for model_id (#211087) (#211110)

Browse source 
# Backport

This will backport the following commits from `main` to `8.18`:
- [[Inference] Updating link text for model_id
(#211087)](https://github.com/elastic/kibana/pull/211087)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Samiul
Monir","email":"150824886+Samiul-TheSoccerFan@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-13T22:05:42Z","message":"[Inference]
Updating link text for model_id (#211087)\n\n## Summary\r\n\r\nUpdating
link text for `model_field` field to have `Learn more.` when\r\nthe
provider is Elasticsearch.\r\n\r\n### screenshots:\r\n\r\n####
Elasticsearch provider\r\n![Screenshot 2025-02-13 at 2
26\r\n13 PM](https://github.com/user-attachments/assets/a4b12e99-c69a-47b4-ba9d-81786f39d82c)\r\n\r\n####
Other providers\r\n![Screenshot 2025-02-13 at 2
26\r\n28 PM](https://github.com/user-attachments/assets/ba35f36b-fc5d-48e5-91cf-1f37b96f95ec)\r\n\r\n\r\n###
Checklist\r\n\r\nCheck the PR satisfies following conditions.
\r\n\r\nReviewers should verify this PR satisfies this list as
well.\r\n\r\n- [X] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\r\n-
[X] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"84fdbcba62206dd010086ae1ec590d6d0f5d16e5","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Inference]
Updating link text for
model_id","number":211087,"url":"https://github.com/elastic/kibana/pull/211087","mergeCommit":{"message":"[Inference]
Updating link text for model_id (#211087)\n\n## Summary\r\n\r\nUpdating
link text for `model_field` field to have `Learn more.` when\r\nthe
provider is Elasticsearch.\r\n\r\n### screenshots:\r\n\r\n####
Elasticsearch provider\r\n![Screenshot 2025-02-13 at 2
26\r\n13 PM](https://github.com/user-attachments/assets/a4b12e99-c69a-47b4-ba9d-81786f39d82c)\r\n\r\n####
Other providers\r\n![Screenshot 2025-02-13 at 2
26\r\n28 PM](https://github.com/user-attachments/assets/ba35f36b-fc5d-48e5-91cf-1f37b96f95ec)\r\n\r\n\r\n###
Checklist\r\n\r\nCheck the PR satisfies following conditions.
\r\n\r\nReviewers should verify this PR satisfies this list as
well.\r\n\r\n- [X] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\r\n-
[X] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"84fdbcba62206dd010086ae1ec590d6d0f5d16e5"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211087","number":211087,"mergeCommit":{"message":"[Inference]
Updating link text for model_id (#211087)\n\n## Summary\r\n\r\nUpdating
link text for `model_field` field to have `Learn more.` when\r\nthe
provider is Elasticsearch.\r\n\r\n### screenshots:\r\n\r\n####
Elasticsearch provider\r\n![Screenshot 2025-02-13 at 2
26\r\n13 PM](https://github.com/user-attachments/assets/a4b12e99-c69a-47b4-ba9d-81786f39d82c)\r\n\r\n####
Other providers\r\n![Screenshot 2025-02-13 at 2
26\r\n28 PM](https://github.com/user-attachments/assets/ba35f36b-fc5d-48e5-91cf-1f37b96f95ec)\r\n\r\n\r\n###
Checklist\r\n\r\nCheck the PR satisfies following conditions.
\r\n\r\nReviewers should verify this PR satisfies this list as
well.\r\n\r\n- [X] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\r\n-
[X] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"84fdbcba62206dd010086ae1ec590d6d0f5d16e5"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Samiul Monir <150824886+Samiul-TheSoccerFan@users.noreply.github.com>
This commit is contained in:
Kibana Machine 2025-02-14 11:11:11 +11:00 • committed by GitHub
parent fbd05120da
commit d2a5735822
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/configuration/configuration_form_items.test.tsx
View file

@ -37,7 +37,7 @@ describe('ConfigurationFormItems', () => {
it('renders link when isInternalProvider is true and key is model_id', () => {
render(<ConfigurationFormItems {...defaultProps} isInternalProvider={true} />);
const link = screen.getByRole('link', { name: /looking for elasticsearch model ids/i });
const link = screen.getByRole('link', { name: /Learn more./i });
expect(link).toBeInTheDocument();
expect(link).toHaveAttribute(
'href',

2
x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/configuration/configuration_form_items.tsx
View file

@ -66,7 +66,7 @@ export const ConfigurationFormItems: React.FC<ConfigurationFormItemsProps> = ({
external
target="_blank"
>
{LABELS.ES_MODELS_LINK_TEXT}
{LABELS.LEARN_MORE}
</EuiLink>
</>
) : (

6
x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/translations.ts
View file

@ -120,10 +120,10 @@ export const OPTIONALTEXT = i18n.translate(
}
);
export const ES_MODELS_LINK_TEXT = i18n.translate(
'xpack.inferenceEndpointUICommon.components.esModelsLinkText',
export const LEARN_MORE = i18n.translate(
'xpack.inferenceEndpointUICommon.components.learnMoreText',
{
defaultMessage: 'Looking for Elasticsearch model Ids',
defaultMessage: 'Learn more.',
}
);