github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Fleet] Fix invalid permission entry if the elastic agent package is not installed (#125447)

Browse source
This commit is contained in:
Nicolas Chaulet 2022-02-14 11:09:15 -05:00 • committed by GitHub
parent 09ff04db09
commit d383bda82e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

9
x-pack/plugins/fleet/server/services/agent_policies/monitoring_permissions.test.ts
View file

@ -43,6 +43,15 @@ describe('getMonitoringPermissions', () => {
);
expect(permissions).toMatchSnapshot();
});
it('should an empty valid permission entry if neither metrics and logs are enabled', async () => {
const permissions = await getMonitoringPermissions(
savedObjectsClientMock.create(),
{ logs: false, metrics: false },
'testnamespace123'
);
expect(permissions).toEqual({ _elastic_agent_monitoring: { indices: [] } });
});
});
describe('With elastic agent package installed', () => {

8
x-pack/plugins/fleet/server/services/agent_policies/monitoring_permissions.ts
View file

@ -30,6 +30,14 @@ function buildDefault(enabled: { logs: boolean; metrics: boolean }, namespace: s
);
}
if (names.length === 0) {
return {
_elastic_agent_monitoring: {
indices: [],
},
};
}
return {
_elastic_agent_monitoring: {
indices: [