[8.x][ci] Run linting before tests (#197310) (#198096)

#197310
2025-04-23 09:19:04 -04:00 · 2024-10-29 16:59:24 -05:00 · 2024-10-29 16:59:24 -05:00 · d3ccb92479
commit d3ccb92479
parent 15aaea8d02
30 changed files with 142 additions and 57 deletions
--- a/.buildkite/pipelines/on_merge.yml
+++ b/.buildkite/pipelines/on_merge.yml
@ -46,6 +46,36 @@ steps:
        - exit_status: '-1'
          limit: 3

+  - command: .buildkite/scripts/steps/lint.sh
+    label: 'Linting'
+    agents:
+      image: family/kibana-ubuntu-2004
+      imageProject: elastic-images-prod
+      provider: gcp
+      machineType: n2-standard-16
+      preemptible: true
+    key: linting
+    timeout_in_minutes: 60
+    retry:
+      automatic:
+        - exit_status: '-1'
+          limit: 3
+
+  - command: .buildkite/scripts/steps/lint_with_types.sh
+    label: 'Linting (with types)'
+    agents:
+      image: family/kibana-ubuntu-2004
+      imageProject: elastic-images-prod
+      provider: gcp
+      machineType: n2-standard-32
+      preemptible: true
+    key: linting_with_types
+    timeout_in_minutes: 90
+    retry:
+      automatic:
+        - exit_status: '-1'
+          limit: 3
+
  - wait

  - command: .buildkite/scripts/steps/on_merge_api_docs.sh
@ -109,6 +139,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 2
    retry:
@ -127,6 +159,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 4
    retry:
@ -145,6 +179,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 6
    retry:
@ -163,6 +199,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 5
    retry:
@ -181,6 +219,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 6
    retry:
@ -199,6 +239,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 1
    retry:
@ -217,6 +259,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 2
    retry:
@ -235,6 +279,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 2
    retry:
@ -253,6 +299,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 6
    retry:
@ -271,6 +319,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 8
    retry:
@ -291,6 +341,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 20
    retry:
@ -304,42 +356,14 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    agents:
      image: family/kibana-ubuntu-2004
      imageProject: elastic-images-prod
      provider: gcp
      machineType: n2-standard-2

-  - command: .buildkite/scripts/steps/lint.sh
-    label: 'Linting'
-    agents:
-      image: family/kibana-ubuntu-2004
-      imageProject: elastic-images-prod
-      provider: gcp
-      machineType: n2-standard-8
-      preemptible: true
-    key: linting
-    timeout_in_minutes: 60
-    retry:
-      automatic:
-        - exit_status: '-1'
-          limit: 3
-
-  - command: .buildkite/scripts/steps/lint_with_types.sh
-    label: 'Linting (with types)'
-    agents:
-      image: family/kibana-ubuntu-2004
-      imageProject: elastic-images-prod
-      provider: gcp
-      machineType: n2-standard-16
-      preemptible: true
-    key: linting_with_types
-    timeout_in_minutes: 90
-    retry:
-      automatic:
-        - exit_status: '-1'
-          limit: 3
-
  - command: .buildkite/scripts/steps/checks.sh
    label: 'Checks'
    agents:
--- a/.buildkite/pipelines/pull_request/apm_cypress.yml
+++ b/.buildkite/pipelines/pull_request/apm_cypress.yml
@ -7,6 +7,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 120
    parallelism: 1 # TODO: Set parallelism when apm_cypress handles it
    retry:
--- a/.buildkite/pipelines/pull_request/base.yml
+++ b/.buildkite/pipelines/pull_request/base.yml
@ -32,6 +32,30 @@ steps:
        - exit_status: '-1'
          limit: 3

+  - command: .buildkite/scripts/steps/lint.sh
+    label: 'Linting'
+    agents:
+      machineType: n2-standard-16
+      preemptible: true
+    key: linting
+    timeout_in_minutes: 60
+    retry:
+      automatic:
+        - exit_status: '-1'
+          limit: 3
+
+  - command: .buildkite/scripts/steps/lint_with_types.sh
+    label: 'Linting (with types)'
+    agents:
+      machineType: n2-standard-32
+      preemptible: true
+    key: linting_with_types
+    timeout_in_minutes: 90
+    retry:
+      automatic:
+        - exit_status: '-1'
+          limit: 3
+
  - wait

  - command: .buildkite/scripts/steps/ci_stats_ready.sh
@ -61,18 +85,6 @@ steps:
        - exit_status: '*'
          limit: 1

-  - command: .buildkite/scripts/steps/lint.sh
-    label: 'Linting'
-    agents:
-      machineType: n2-standard-8
-      preemptible: true
-    key: linting
-    timeout_in_minutes: 60
-    retry:
-      automatic:
-        - exit_status: '-1'
-          limit: 3
-
  - command: .buildkite/scripts/steps/check_types.sh
    label: 'Check Types'
    agents:
@ -85,18 +97,6 @@ steps:
        - exit_status: '-1'
          limit: 3

-  - command: .buildkite/scripts/steps/lint_with_types.sh
-    label: 'Linting (with types)'
-    agents:
-      machineType: n2-standard-16
-      preemptible: true
-    key: linting_with_types
-    timeout_in_minutes: 90
-    retry:
-      automatic:
-        - exit_status: '-1'
-          limit: 3
-
  - command: .buildkite/scripts/steps/checks.sh
    label: 'Checks'
    key: checks
--- a/.buildkite/pipelines/pull_request/deploy_cloud.yml
+++ b/.buildkite/pipelines/pull_request/deploy_cloud.yml
@ -7,6 +7,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 30
    soft_fail: true
    retry:
--- a/.buildkite/pipelines/pull_request/exploratory_view_plugin.yml
+++ b/.buildkite/pipelines/pull_request/exploratory_view_plugin.yml
@ -7,6 +7,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 60
    artifact_paths:
      - 'x-pack/plugins/observability_solution/exploratory_view/e2e/.journeys/**/*'
--- a/.buildkite/pipelines/pull_request/fips.yml
+++ b/.buildkite/pipelines/pull_request/fips.yml
@ -7,6 +7,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 60
    soft_fail: true
    retry:
--- a/.buildkite/pipelines/pull_request/fleet_cypress.yml
+++ b/.buildkite/pipelines/pull_request/fleet_cypress.yml
@ -7,6 +7,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 50
    parallelism: 6
    retry:
--- a/.buildkite/pipelines/pull_request/inventory_cypress.yml
+++ b/.buildkite/pipelines/pull_request/inventory_cypress.yml
@ -7,6 +7,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 120
    parallelism: 1
    retry:
--- a/.buildkite/pipelines/pull_request/kbn_handlebars.yml
+++ b/.buildkite/pipelines/pull_request/kbn_handlebars.yml
@ -7,6 +7,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 5
    retry:
      automatic:
--- a/.buildkite/pipelines/pull_request/observability_onboarding_cypress.yml
+++ b/.buildkite/pipelines/pull_request/observability_onboarding_cypress.yml
@ -7,6 +7,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 120
    retry:
      automatic:
--- a/.buildkite/pipelines/pull_request/profiling_cypress.yml
+++ b/.buildkite/pipelines/pull_request/profiling_cypress.yml
@ -7,6 +7,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 120
    parallelism: 2
    retry:
--- a/.buildkite/pipelines/pull_request/response_ops.yml
+++ b/.buildkite/pipelines/pull_request/response_ops.yml
@ -7,6 +7,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 120
    parallelism: 9
    retry:
--- a/.buildkite/pipelines/pull_request/response_ops_cases.yml
+++ b/.buildkite/pipelines/pull_request/response_ops_cases.yml
@ -7,6 +7,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 120
    retry:
      automatic:
--- a/.buildkite/pipelines/pull_request/security_solution/ai_assistant.yml
+++ b/.buildkite/pipelines/pull_request/security_solution/ai_assistant.yml
@ -7,6 +7,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 1
    retry:
--- a/.buildkite/pipelines/pull_request/security_solution/cloud_security_posture.yml
+++ b/.buildkite/pipelines/pull_request/security_solution/cloud_security_posture.yml
@ -7,6 +7,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 1
    retry:
@ -22,6 +24,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 1
    retry:
--- a/.buildkite/pipelines/pull_request/security_solution/cypress_burn.yml
+++ b/.buildkite/pipelines/pull_request/security_solution/cypress_burn.yml
@ -9,6 +9,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 60
    soft_fail: true
    parallelism: 1
@ -23,6 +25,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 1
    retry:
@ -37,6 +41,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 50
    soft_fail: true
    retry:
--- a/.buildkite/pipelines/pull_request/security_solution/defend_workflows.yml
+++ b/.buildkite/pipelines/pull_request/security_solution/defend_workflows.yml
@ -9,6 +9,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 20
    retry:
--- a/.buildkite/pipelines/pull_request/security_solution/detection_engine.yml
+++ b/.buildkite/pipelines/pull_request/security_solution/detection_engine.yml
@ -7,6 +7,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 5
    retry:
@ -22,6 +24,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 2
    retry:
--- a/.buildkite/pipelines/pull_request/security_solution/entity_analytics.yml
+++ b/.buildkite/pipelines/pull_request/security_solution/entity_analytics.yml
@ -7,6 +7,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 2
    retry:
--- a/.buildkite/pipelines/pull_request/security_solution/explore.yml
+++ b/.buildkite/pipelines/pull_request/security_solution/explore.yml
@ -7,6 +7,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 2
    retry:
--- a/.buildkite/pipelines/pull_request/security_solution/investigations.yml
+++ b/.buildkite/pipelines/pull_request/security_solution/investigations.yml
@ -7,6 +7,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 7
    retry:
--- a/.buildkite/pipelines/pull_request/security_solution/osquery_cypress.yml
+++ b/.buildkite/pipelines/pull_request/security_solution/osquery_cypress.yml
@ -7,6 +7,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 8
    retry:
--- a/.buildkite/pipelines/pull_request/security_solution/playwright.yml
+++ b/.buildkite/pipelines/pull_request/security_solution/playwright.yml
@ -7,6 +7,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 1
    retry:
--- a/.buildkite/pipelines/pull_request/security_solution/rule_management.yml
+++ b/.buildkite/pipelines/pull_request/security_solution/rule_management.yml
@ -7,6 +7,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 4
    retry:
@ -22,6 +24,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 2
    retry:
--- a/.buildkite/pipelines/pull_request/slo_plugin_e2e.yml
+++ b/.buildkite/pipelines/pull_request/slo_plugin_e2e.yml
@ -7,6 +7,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 30
    artifact_paths:
      - 'x-pack/plugins/observability_solution/slo/e2e/.journeys/**/*'
--- a/.buildkite/pipelines/pull_request/synthetics_plugin.yml
+++ b/.buildkite/pipelines/pull_request/synthetics_plugin.yml
@ -7,6 +7,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 60
    artifact_paths:
      - 'x-pack/plugins/observability_solution/synthetics/e2e/.journeys/**/*'
--- a/.buildkite/pipelines/pull_request/uptime_plugin.yml
+++ b/.buildkite/pipelines/pull_request/uptime_plugin.yml
@ -7,6 +7,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 60
    artifact_paths:
      - 'x-pack/plugins/observability_solution/synthetics/e2e/.journeys/**/*'
--- a/.buildkite/pipelines/pull_request/ux_plugin_e2e.yml
+++ b/.buildkite/pipelines/pull_request/ux_plugin_e2e.yml
@ -7,6 +7,8 @@ steps:
    depends_on:
      - build
      - quick_checks
+      - linting
+      - linting_with_types
    timeout_in_minutes: 60
    artifact_paths:
      - 'x-pack/plugins/observability_solution/ux/e2e/.journeys/**/*'
--- a/.buildkite/scripts/steps/checks/quick_checks.txt
+++ b/.buildkite/scripts/steps/checks/quick_checks.txt
@ -1,4 +1,3 @@
-.buildkite/scripts/steps/checks/precommit_hook.sh
 .buildkite/scripts/steps/checks/ts_projects.sh
 .buildkite/scripts/steps/checks/packages.sh
 .buildkite/scripts/steps/checks/bazel_packages.sh
--- a/.buildkite/scripts/steps/lint.sh
+++ b/.buildkite/scripts/steps/lint.sh
@ -15,9 +15,9 @@ echo '--- Lint: eslint'
 # after possibly commiting fixed files to the repo
 set +e;
 if is_pr && ! is_auto_commit_disabled; then
-  git ls-files | grep -E '\.(js|mjs|ts|tsx)$' | xargs -n 250 -P 4 node scripts/eslint --no-cache --fix
+  git ls-files | grep -E '\.(js|mjs|ts|tsx)$' | xargs -n 250 -P 8 node scripts/eslint --no-cache --fix
 else
-  git ls-files | grep -E '\.(js|mjs|ts|tsx)$' | xargs -n 250 -P 4 node scripts/eslint --no-cache
+  git ls-files | grep -E '\.(js|mjs|ts|tsx)$' | xargs -n 250 -P 8 node scripts/eslint --no-cache
 fi

 eslint_exit=$?