github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Guided onboarding] Observability tour: Fixed the last step offset (#136861)

Browse source 
[Guided onboarding] Observability tour: Moved traces step to services

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Yulia Čech 2022-07-25 14:58:14 +02:00 • committed by GitHub
parent 9005813b78
commit d3ef7419e8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 14 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

0
x-pack/plugins/observability/public/assets/onboarding_tour_step_traces.gif → x-pack/plugins/observability/public/assets/onboarding_tour_step_services.gif
View file

Side by side Swipe Overlay

Before

Width:  |  Height:  |  Size: 268 KiB

After

Width:  |  Height:  |  Size: 268 KiB

Before After
Before After

16
x-pack/plugins/observability/public/components/shared/tour/steps_config.ts
View file

@ -14,6 +14,7 @@ interface TourStep {
anchorPosition: EuiTourStepProps['anchorPosition'];
title: EuiTourStepProps['title'];
dataTestSubj: string;
offset?: number;
imageConfig?: {
name: string;
altText: string;
@ -70,20 +71,20 @@ export const tourStepsConfig: TourStep[] = [
},
},
{
title: i18n.translate('xpack.observability.tour.tracesStep.tourTitle', {
title: i18n.translate('xpack.observability.tour.servicesStep.tourTitle', {
defaultMessage: 'Identify and resolve application issues',
}),
content: i18n.translate('xpack.observability.tour.tracesStep.tourContent', {
content: i18n.translate('xpack.observability.tour.servicesStep.tourContent', {
defaultMessage:
'Find and fix performance problems quickly by collecting detailed information about your services.',
}),
anchor: `[data-nav-id="traces"]`,
anchor: `[data-nav-id="services"]`,
anchorPosition: 'rightUp',
dataTestSubj: 'tracesStep',
dataTestSubj: 'servicesStep',
imageConfig: {
name: 'onboarding_tour_step_traces.gif',
altText: i18n.translate('xpack.observability.tour.tracesStep.imageAltText', {
defaultMessage: 'Traces demonstration',
name: 'onboarding_tour_step_services.gif',
altText: i18n.translate('xpack.observability.tour.servicesStep.imageAltText', {
defaultMessage: 'Services demonstration',
}),
},
},
@ -116,5 +117,6 @@ export const tourStepsConfig: TourStep[] = [
anchor: '#guidedSetupButton',
anchorPosition: 'rightUp',
dataTestSubj: 'guidedSetupStep',
offset: 10,
},
];

4
x-pack/plugins/observability/public/components/shared/tour/tour.tsx
View file

@ -101,7 +101,7 @@ const getSteps = ({
return tourStepsConfig.map((stepConfig, index) => {
const step = index + 1;
const { dataTestSubj, content, imageConfig, ...tourStepProps } = stepConfig;
const { dataTestSubj, content, offset: stepOffset, imageConfig, ...tourStepProps } = stepConfig;
return (
<EuiTourStep
{...tourStepProps}
@ -109,7 +109,7 @@ const getSteps = ({
step={step}
minWidth={minWidth}
maxWidth={maxWidth}
offset={offset}
offset={stepOffset ?? offset}
repositionOnScroll={repositionOnScroll}
stepsTotal={tourStepsConfig.length}
isStepOpen={step === activeStep}

6
x-pack/test/functional/apps/infra/tour.ts
View file

@ -60,10 +60,10 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
await pageObjects.infraHome.clickTourNextButton();
await pageObjects.infraHome.ensureTourStepIsClosed('metricsExplorerStep');
// Step 4: Traces
await pageObjects.infraHome.waitForTourStep('tracesStep');
// Step 4: Services
await pageObjects.infraHome.waitForTourStep('servicesStep');
await pageObjects.infraHome.clickTourNextButton();
await pageObjects.infraHome.ensureTourStepIsClosed('tracesStep');
await pageObjects.infraHome.ensureTourStepIsClosed('servicesStep');
// Step 5: Alerts
await pageObjects.infraHome.waitForTourStep('alertStep');