github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Metrics UI] Re-enabled saved view tests (#108725)

Browse source 
* [Metrics UI] Re-enabled saved view tests

* Adding ensureViewIsLoadable back in

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Chris Cowan 2021-08-20 11:33:04 -06:00 • committed by GitHub
parent e8e53e36e5
commit d4b4b0e7b0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

3
x-pack/test/functional/apps/infra/home_page.ts
View file

@ -87,8 +87,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
});
});
// FLAKY: https://github.com/elastic/kibana/issues/106660
describe.skip('Saved Views', () => {
describe('Saved Views', () => {
before(() => esArchiver.load('x-pack/test/functional/es_archives/infra/metrics_and_logs'));
after(() => esArchiver.unload('x-pack/test/functional/es_archives/infra/metrics_and_logs'));
it('should have save and load controls', async () => {

3
x-pack/test/functional/apps/infra/metrics_explorer.ts
View file

@ -87,8 +87,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
});
});
// FLAKY: https://github.com/elastic/kibana/issues/106651
describe.skip('Saved Views', () => {
describe('Saved Views', () => {
before(() => esArchiver.load('x-pack/test/functional/es_archives/infra/metrics_and_logs'));
after(() => esArchiver.unload('x-pack/test/functional/es_archives/infra/metrics_and_logs'));
describe('save functionality', () => {

5
x-pack/test/functional/page_objects/infra_saved_views.ts
View file

@ -79,9 +79,8 @@ export function InfraSavedViewsProvider({ getService }: FtrProviderContext) {
},
async ensureViewIsLoadable(name: string) {
const subjects = await testSubjects.getVisibleTextAll('savedViews-loadList');
const includesName = subjects.some((s) => s.includes(name));
expect(includesName).to.be(true);
const subject = await testSubjects.find('savedViews-loadList');
await subject.findByCssSelector(`li[title="${name}"]`);
},
async closeSavedViewsLoadModal() {