github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

[page_objects/visual_builder_page] fixes #29670 with proper wait for visualization loaded (#29741) (#29815)

Browse source
This commit is contained in:
Dmitry Lemeshko 2019-02-01 11:56:32 +01:00 • committed by GitHub
parent 9295e8f158
commit d4e5f3d766
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
test/functional/page_objects/visual_builder_page.js
View file

@ -60,6 +60,7 @@ export function VisualBuilderPageProvider({ getService, getPageObjects }) {
}
async enterMarkdown(markdown) {
const prevRenderingCount = await PageObjects.visualize.getVisualizationRenderingCount();
const input = await find.byCssSelector('.tvbMarkdownEditor__editor textarea');
// Since we use ACE editor and that isn't really storing its value inside
// a textarea we must really select all text and remove it, and cannot use
@ -72,7 +73,7 @@ export function VisualBuilderPageProvider({ getService, getPageObjects }) {
await browser.pressKeys(Keys.NULL); // Release modifier keys
await browser.pressKeys(Keys.BACKSPACE); // Delete all content
await input.type(markdown);
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.visualize.waitForRenderingCount(prevRenderingCount + 1);
}
async getMarkdownText() {