github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

Replace and remove static sleep calls

Browse source 
Any `sleep()` calls preceding a `verifyChartData()` call seem to be
redundant, because `verifyChartData()` already uses `try()` to avoid
flakyness due to timing.

A few more assertions are now wrapped in `try()` calls to avoid
occasional failures due to the timing of rendering.
This commit is contained in:
Felix Stürmer 2016-10-12 12:12:25 +02:00
parent 88c0b7b75e
commit d4f717016f
No known key found for this signature in database
GPG key ID: F938FEB4935329DA
1 changed files with 6 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

18
test/functional/apps/discover/_discover.js
View file

@ -54,22 +54,20 @@ bdd.describe('discover app', function describeIndexTests() {
bdd.it('load query should show query name', async function () {
await PageObjects.discover.loadSavedSearch(queryName1);
await PageObjects.common.sleep(3000);
var actualQueryNameString = await PageObjects.discover.getCurrentQueryName();
await PageObjects.common.saveScreenshot('Discover-load-query');
expect(actualQueryNameString).to.be(queryName1);
await PageObjects.common.try(async function() {
expect(await PageObjects.discover.getCurrentQueryName()).to.be(queryName1);
});
});
bdd.it('should show the correct hit count', async function () {
var hitCount = await PageObjects.discover.getHitCount();
expect(hitCount).to.be('14,004');
await PageObjects.common.try(async function() {
expect(await PageObjects.discover.getHitCount()).to.be('14,004');
});
});
bdd.it('should show the correct bar chart', async function () {
await PageObjects.common.sleep(4000);
var expectedBarChartData = [ '3.237',
'17.674', '64.75', '125.737', '119.962', '65.712', '16.449',
'2.712', '3.675', '17.674', '59.762', '119.087', '123.812',
@ -93,7 +91,6 @@ bdd.describe('discover app', function describeIndexTests() {
bdd.it('should show correct data for chart interval Hourly', async function () {
await PageObjects.discover.setChartInterval('Hourly');
await PageObjects.common.sleep(4000);
var expectedBarChartData = [ '1.527', '2.290',
'5.599', '7.890', '13.236', '30.290', '46.072', '55.490', '86.8',
@ -151,7 +148,6 @@ bdd.describe('discover app', function describeIndexTests() {
var expectedBarChartData = [ '122.535'];
await PageObjects.discover.setChartInterval(chartInterval);
await PageObjects.common.sleep(2000);
await verifyChartData(expectedBarChartData);
});
@ -160,7 +156,6 @@ bdd.describe('discover app', function describeIndexTests() {
var expectedBarChartData = [ '122.535'];
await PageObjects.discover.setChartInterval(chartInterval);
await PageObjects.common.sleep(2000);
await verifyChartData(expectedBarChartData);
});
@ -174,7 +169,6 @@ bdd.describe('discover app', function describeIndexTests() {
];
await PageObjects.discover.setChartInterval(chartInterval);
await PageObjects.common.sleep(4000);
await verifyChartData(expectedBarChartData);
});