github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

Use data-id attribute to select loading message, instead of CSS class since that creates a brittle coupling between JS and CSS.

Browse source 
- Formalize this rule in the CSS style guide.
This commit is contained in:
CJ Cenizal 2016-11-29 10:28:48 -07:00
parent 8a528dcd97
commit d5747639cc
1 changed files with 11 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

17
src/ui/views/ui_app.jade
View file

@ -110,23 +110,28 @@ block content
opacity: 0.8;
}
.kibanaWelcomeView
.kibanaWelcomeView(
data-id="kibanaWelcomeView"
)
.kibanaLoader
.kibanaLoader__logo
.kibanaWelcomeLogo
.kibanaLoader__content
| Loading Kibana
.kibanaLoadingMessage.
Give me a moment here. I’m loading a whole bunch of code. Don’t worry, all this
good stuff will be cached up for next time!
.kibanaLoadingMessage(
data-id="kibanaLoadingMessage"
)
| Give me a moment here. I’m loading a whole bunch of code. Don’t worry, all this
| good stuff will be cached up for next time!
script.
window.onload = function () {
var hideLoadingMessage = /#.*[?&]embed(&|$|=true)/.test(window.location.href);
if (hideLoadingMessage) {
var loading = document.querySelector('.kibanaWelcomeView');
loading.removeChild(loading.lastChild);
var loadingContainer = document.querySelector('[data-id="kibanaWelcomeView"]');
var loadingMessage = document.querySelector('[data-id="kibanaLoadingMessage"]');
loadingContainer.removeChild(loadingMessage);
}
var buildNum = #{kibanaPayload.buildNum};