github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS.

Browse source
This commit is contained in:
CJ Cenizal 2019-08-04 12:36:53 -07:00
parent 15c43b73ef
commit d5ce67f5ed
2 changed files with 7 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

1
.github/CODEOWNERS vendored
View file

@ -58,6 +58,7 @@
# Elasticsearch UI
/src/legacy/core_plugins/console/ @elastic/es-ui
/src/plugins/es_ui_shared/ @elastic/es-ui
/x-pack/legacy/plugins/console_extensions/ @elastic/es-ui
/x-pack/legacy/plugins/cross_cluster_replication/ @elastic/es-ui
/x-pack/legacy/plugins/index_lifecycle_management/ @elastic/es-ui

9
src/plugins/es_ui_shared/public/request/request.test.js
View file

@ -103,7 +103,8 @@ describe('request lib', () => {
});
});
describe('pollIntervalMs', () => {
// FLAKY: https://github.com/elastic/kibana/issues/42561
describe.skip('pollIntervalMs', () => {
it('sends another request after the specified time has elapsed', async () => {
initUseRequest({ ...successRequest, pollIntervalMs: 30 });
await wait(5);
@ -173,7 +174,8 @@ describe('request lib', () => {
expect(hook.error).toBe(errorResponse);
});
it('persists while a request is in-flight', async () => {
// FLAKY: https://github.com/elastic/kibana/issues/42563
it.skip('persists while a request is in-flight', async () => {
initUseRequest({ ...errorRequest });
await wait(5);
hook.sendRequest();
@ -204,7 +206,8 @@ describe('request lib', () => {
expect(hook.data).toBe(successResponse.data);
});
it('is undefined when the request fails', async () => {
// FLAKY: https://github.com/elastic/kibana/issues/42562
it.skip('is undefined when the request fails', async () => {
initUseRequest({ ...errorRequest });
await wait(10);
expect(hook.isLoading).toBe(false);