github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

Change signature of Plugin.stop to maybe async (#170225)

Browse source 
## Summary

Fix https://github.com/elastic/kibana/issues/83612

This PR doesn't change any behavior, as we're already supporting (and
awaiting) promises returned from `stop` calls to plugin, it just changes
the type's signature to reflect that.

Also removed empty `stop` methods from existing plugins to make
typescript happy.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Pierre Gayvallet 2023-11-06 09:38:19 +01:00 • committed by GitHub
parent 9def79267c
commit d64e246cb7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 7 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

4
x-pack/plugins/runtime_fields/public/plugin.ts
View file

@ -22,8 +22,4 @@ export class RuntimeFieldsPlugin
public start(core: CoreStart, plugins: StartPlugins) {
return {};
}
public stop() {
return {};
}
}